[txnId_Fix] Add txn_id while metadata appending (if exist) #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Nikitin <andrew.nikitin@dsr-corporation.com>
ashcherbakov
requested changes
Jun 5, 2018
plenum/common/txn_util.py
Outdated
| append_txn_metadata(txn, | ||
| seq_no=seq_no, | ||
| txn_time=txn_time, | ||
| txn_id=t.get(TXN_ID, None)) |
There was a problem hiding this comment.
TXN_ID needs to be popped from the txn's data, doens't it?
There was a problem hiding this comment.
No, txnId is placed on the top level of txn
Signed-off-by: Andrew Nikitin <andrew.nikitin@dsr-corporation.com>
ashcherbakov
reviewed
Jun 5, 2018
| txn = do_req_to_txn(req_data=t, | ||
| req_op=t) | ||
| append_txn_metadata(txn, seq_no=seq_no, txn_time=txn_time) | ||
| append_txn_metadata(txn, |
There was a problem hiding this comment.
Please add a test (extend test_new_txn_format)
Signed-off-by: Andrew Nikitin <andrew.nikitin@dsr-corporation.com>
ashcherbakov
approved these changes
Jun 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andrew Nikitin andrew.nikitin@dsr-corporation.com