abstract comparison logic to a method and return small values as comp… #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arison result Signed-off-by: Lovesh Harchandani <lovesh.bond@gmail.com>
|
|
||
|
|
||
| def initKeyValueStorage(keyValueType, dataLocation, keyValueStorageName, | ||
| open=True, read_only=False) -> KeyValueStorage: | ||
| from storage.kv_store_leveldb import KeyValueStorageLeveldb |
There was a problem hiding this comment.
why are we importing in the function?
There was a problem hiding this comment.
To avoid the circular dependency. The storage specific files also import helper.py
|
Test this please |
devin-fisher
approved these changes
Jun 12, 2018
|
Test this please |
1 similar comment
|
Test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…arison result
Signed-off-by: Lovesh Harchandani lovesh.bond@gmail.com