Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INDY-1464: fix Propagate request for ATTRIB txn #807

Merged
merged 3 commits into from
Jul 12, 2018
Merged

INDY-1464: fix Propagate request for ATTRIB txn #807

merged 3 commits into from
Jul 12, 2018

Conversation

ashcherbakov
Copy link
Contributor

@ashcherbakov ashcherbakov commented Jul 11, 2018 •
edited

  • use correct Request class when processing requested PROPAGATE (since request class is overridden in indy-node)
  • use correct Request class in reqToTxn
  • the tests are in reqTotxn (since request class is overridden in indy-node)
  • fixed a small issue in SigningSerializer
  • added tests for SigningSerializer (there is an issue there: INDY-1469)
  • the tests for propagation of ATTRIB are in fix Propagate request for ATTRIB txn indy-node#816

Signed-off-by: ashcherbakov alexander.sherbakov@dsr-company.com

@ashcherbakov
hotfix for None value as MessageResponse
1b43123 
Signed-off-by: ashcherbakov <alexander.sherbakov@dsr-company.com>
@ashcherbakov
use correct Request class in processing PROPOGATE requests.
6e60b4f 
Signed-off-by: ashcherbakov <alexander.sherbakov@dsr-company.com>
@ashcherbakov
use correct Request class in reqToTxn
182ec8c 
Signed-off-by: ashcherbakov <alexander.sherbakov@dsr-company.com>
@ashcherbakov ashcherbakov changed the title hotfix for None value as MessageResponse INDY-1464: hotfix for None value as MessageResponse Jul 11, 2018
@ashcherbakov ashcherbakov changed the title INDY-1464: hotfix for None value as MessageResponse INDY-1464: fix Propagate request for ATTRIB txn Jul 11, 2018
@ashcherbakov ashcherbakov merged commit 5c26101 into master Jul 12, 2018
@ashcherbakov ashcherbakov deleted the fix/request-propagate branch July 18, 2018 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andkononykhin andkononykhin andkononykhin approved these changes

@vimmerru vimmerru vimmerru approved these changes

@dsurnin dsurnin dsurnin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ashcherbakov @andkononykhin @vimmerru @dsurnin