INDY-1461: add the test for different prepare certificates in view change #815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
| quorum) | ||
|
|
||
|
|
||
| def test_view_change_with_different_prepare_certificate(looper, txnPoolNodeSet, |
There was a problem hiding this comment.
Why don't we just create a simple unit test that just adds a quorum of Prepares from other nodes, but doesn't add PrePrepare?
See test_lst_sertificate_return_max_3PC_key_of_quorumed_prepare as an example.
There was a problem hiding this comment.
Because we want to check that the prepare does not get in replica.prepares without preprepare. It will be more useful with an integration tests.
ashcherbakov
approved these changes
Jul 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check that a node without pre-prepare but with quorum of prepares wouldn't use this transaction as a last in prepare certificate