Add config for initial propose viewchange timeout #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
| @@ -272,6 +272,7 @@ | |||
| MAX_STACK_RESTART_TIME_DEVIATION = 300 # seconds | |||
|
|
|||
| VIEW_CHANGE_TIMEOUT = 600 # seconds | |||
| INITIAL_PROPOSE_VIEW_CHANGE_TIMEOUT = 60 | |||
There was a problem hiding this comment.
Don't we need to patch (reduce) the tests dealing with this timeout?
There was a problem hiding this comment.
It might be necessary, but it should be done either in some central place (btw, do we have same for VIEW_CHANGE_TIMEOUT and CATCHUP_TIMEOUT?), or on case by case basis when tests start to fail with timeouts (and it seems like no tests failed for now)
added 2 commits
July 23, 2018 12:39
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
ashcherbakov
approved these changes
Jul 23, 2018
|
(ci) test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sergey Khoroshavin sergey.khoroshavin@dsr-corporation.com