INDY-1431: add listener bind retries. #838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergey Shilov <sergey.shilov@dsr-company.com>
| @@ -90,7 +90,6 @@ def handle_listener_events(self): | |||
| def restart(self): | |||
| logger.warning("Stopping client stack on node {}".format(self)) | |||
| self.stop() | |||
| time.sleep(0.2) | |||
There was a problem hiding this comment.
Don't we need this timeout anymore?
There was a problem hiding this comment.
This time out has gone to binding cycle if it is needed (i.e. busy port).
There was a problem hiding this comment.
But I was thinking that this timeout was added with a different purpose, to have a chance for sockets to be closed, isn't it?
There was a problem hiding this comment.
No, connection sockets are not closed during TIME_WAIT (~2 mins). This time out was added just for sure that the kernel freed listener socket structure. But our tests under syn flood shows that it is not enough. So I've implemented a logic to have more chances to re-bind in case of immediate stack restart.
ashcherbakov
approved these changes
Jul 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sergey Shilov sergey.shilov@dsr-company.com