INDY-1519: Fixed handling of message replies #841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
spivachuk
commented
Jul 26, 2018
spivachuk
commented
- Added an integration test verifying catch-up in case one of nodes sends MessageReps with LedgerStatuses in outdated format.
- Added unit tests for some unhandled cases in message request / response handling logic.
- Added handling for these cases to message request / response processing logic.
- Added handling of TypeError to the logic of replied message creation in the handler of replies to message requests. Signed-off-by: Nikita Spivachuk <nikita.spivachuk@dsr-company.com> (cherry picked from commit d997d38) Signed-off-by: Nikita Spivachuk <nikita.spivachuk@dsr-company.com>
Test case when one node restart and in catchup receive Ledger Status without protocol version from the one of nodes in pool. Signed-off-by: toktar <renata.toktar@dsr-corporation.com> (cherry picked from commit 25a5ddd) Signed-off-by: Nikita Spivachuk <nikita.spivachuk@dsr-company.com>
Add check discarding a Ledger Statuses from the break_node for all ledgers Signed-off-by: toktar <renata.toktar@dsr-corporation.com> (cherry picked from commit 5dfb165) Signed-off-by: Nikita Spivachuk <nikita.spivachuk@dsr-company.com>
- Added unit tests for some unhandled cases in message request / response handling logic. - Added handling for these cases to message request / response processing logic. Signed-off-by: Nikita Spivachuk <nikita.spivachuk@dsr-company.com> (cherry picked from commit ee53c66) Signed-off-by: Nikita Spivachuk <nikita.spivachuk@dsr-company.com>
Signed-off-by: Nikita Spivachuk <nikita.spivachuk@dsr-company.com>
|
test this please |
ashcherbakov
approved these changes
Jul 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.