INDY-1475: Preparation for statistics processing script #843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
July 26, 2018 18:23
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
| @@ -703,6 +703,7 @@ def trackBatches(self, pp: PrePrepare, prevStateRootHash): | |||
| # tracked to revert this PRE-PREPARE | |||
| self.logger.trace('{} tracking batch for {} with state root {}'.format( | |||
| self, pp, prevStateRootHash)) | |||
| self.metrics.add_event(MetricsType.THREE_PC_BATCH_SIZE, len(pp.reqIdr)) | |||
There was a problem hiding this comment.
Should we consider 3PC Batch size for different Replicas separately? maybe not now, but for future.
There was a problem hiding this comment.
@ashcherbakov yes, this is an interesting thing to add in future, as well as some others, like message sizes per type
|
|
||
| assert acc.count == len(values) | ||
| assert acc.sum == sum(values) | ||
| assert acc.avg == statistics.mean(values) |
There was a problem hiding this comment.
Why do we use statistics module only in tests and not in ValueAccumulator for calculation?
There was a problem hiding this comment.
@ashcherbakov because ValueAccumulator doesn't store values (there can be billions of them when analyzing metrics from a long run), and one of purposes of this test is to be sure that it's implementation is accurate enough
ashcherbakov
approved these changes
Jul 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sergey Khoroshavin sergey.khoroshavin@dsr-corporation.com