INDY-1583: Fix bls signature checking #890
Conversation
Signed-off-by: ArtObr <artemobruchnikov@gmail.com>
| @@ -76,6 +76,11 @@ def get_for_root_hash(self, root_hash, key: bytes) -> Optional[bytes]: | |||
| if val: | |||
| return self.get_decoded(val) | |||
|
|
|||
| def get_all_leaves_for_root_hash(self, root_hash): | |||
There was a problem hiding this comment.
Please add a test for this
| del node.nodeReg[node_name] | ||
|
|
||
| # Still we can validate Preprepare | ||
| assert node.master_replica._bls_bft_replica._bls_bft.bls_key_register.get_key_by_name(node_name) |
There was a problem hiding this comment.
We need to make sure that _load_keys_for_root is called.
Can we write a test for BlsKeyRegisterPoolManager._load_keys_for_root where we take some old pool_state_root_hash?
Actually we need to check the initial case: demote the node, and call _load_keys_for_root for a pool state before demotion.
Signed-off-by: ArtObr <artemobruchnikov@gmail.com>
ArtObr
changed the title
Signed-off-by: ArtObr <artemobruchnikov@gmail.com>
state/test/test_pruning_state.py
Outdated
| @@ -261,6 +261,10 @@ def test_get_for_old_root(state): | |||
| assert state.get_for_root_hash(head_hash2, b'k2') == b'v2' | |||
| assert state.get_for_root_hash(head_hash2, b'k3') == b'v3' | |||
|
|
|||
| assert len(state.get_all_leaves_for_root_hash(head_hash1)) == 2 | |||
There was a problem hiding this comment.
Please add a specific test for get_all_leaves_for_root_hash and check the content as well, not only length.
| def get_current_bls_keys(node): | ||
| return node.master_replica._bls_bft_replica._bls_bft.bls_key_register._current_bls_keys | ||
|
|
||
| restarted_node.master_replica._bls_bft_replica._bls_bft.bls_key_register._load_keys_for_root(state_root_hash) |
There was a problem hiding this comment.
Why do we need to call it? It's assumed already be called when processing last requests.
| node_to_demote = txnPoolNodeSet[4] | ||
| txnPoolNodeSet.remove(node_to_demote) | ||
|
|
||
| last_pre_prepare = \ |
There was a problem hiding this comment.
These lines are not used and can be removed
| assert node.master_replica._bls_bft_replica._bls_bft.bls_key_register.get_key_by_name(node_name) | ||
|
|
||
|
|
||
| def test_bls_not_depend_on_node_reg_demotion(looper, txnPoolNodeSet, |
There was a problem hiding this comment.
A better name for the test: test_order_after_demote_and_restart
| from plenum.common.config_helper import PNodeConfigHelper | ||
| from plenum.common.types import f | ||
|
|
||
| nodeCount = 7 |
There was a problem hiding this comment.
I think we need to make nodeCount = 4 to make sue that we can order after demotion and restart
| # We've removed one of the nodes from another node's log | ||
| del node.nodeReg[node_name] | ||
|
|
||
| # Still we can validate Preprepare |
There was a problem hiding this comment.
Please call _load_keys_for_root here
Signed-off-by: ArtObr <artemobruchnikov@gmail.com>
ArtObr
changed the title
|
test this please |
Signed-off-by: ArtObr <artemobruchnikov@gmail.com>
|
test this please |
Signed-off-by: ArtObr artemobruchnikov@gmail.com