[INDY-1599] Add strategies for latency measurement #892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
August 22, 2018 10:37
Signed-off-by: Andrew Nikitin <andrew.nikitin@dsr-corporation.com>
Signed-off-by: Andrew Nikitin <andrew.nikitin@dsr-corporation.com>
Signed-off-by: Andrew Nikitin <andrew.nikitin@dsr-corporation.com>
Signed-off-by: Andrew Nikitin <andrew.nikitin@dsr-corporation.com>
plenum/server/monitor.py
Outdated
| return self.avg_latency | ||
|
|
||
|
|
||
| class ClientsLatencyForAll(metaclass=ABCMeta): |
There was a problem hiding this comment.
Why do we need this class?
plenum/server/monitor.py
Outdated
| pass | ||
|
|
||
|
|
||
| class MedianHighLatencyForAllClients(MedianHighStrategy): |
There was a problem hiding this comment.
Why do we need this class? Why don't use MedianHighStrategy strategy?
plenum/config.py
Outdated
| @@ -322,3 +324,7 @@ | |||
| METRICS_KV_STORAGE = KeyValueStorageType.Rocksdb | |||
| METRICS_KV_DB_NAME = 'metrics_db' | |||
| METRICS_KV_CONFIG = rocksdb_default_config.copy() | |||
|
|
|||
| AvgStrategyForAllClients = MedianHighLatencyForAllClients | |||
There was a problem hiding this comment.
Why not MedianHighStrategy directly?
plenum/server/node.py
Outdated
| for instId in self.instances.backupIds: | ||
| lat = self.monitor.getLatency(instId) | ||
| if lat: | ||
| backup_latencies.append(lat) | ||
| if len(backup_latencies) > 0: | ||
| self.metrics.add_event(MetricsName.BACKUP_MONITOR_AVG_LATENCY, mean(backup_latencies)) |
There was a problem hiding this comment.
Please use latency_avg_for_backup_cls here
|
|
||
| import pytest | ||
|
|
||
| from plenum.server.monitor import EMALatencyMeasurementForAllClient, EMALatencyMeasurementForEachClient |
There was a problem hiding this comment.
The file name is test_EMALatencyMeasurementForAllClient.py while we are testing EMALatencyMeasurementForEachClient.
Can we test both BTW?
| fill_durations(liB, clientB1) | ||
| fill_durations(liB, clientB2) | ||
|
|
||
| assert liM.get_avg_latency() - liB.get_avg_latency() < tconf.OMEGA |
There was a problem hiding this comment.
Can we also add a test where liM.get_avg_latency() - liB.get_avg_latency() >= tconf.OMEGA
added 6 commits
August 29, 2018 17:06
Signed-off-by: Andrew Nikitin <andrew.nikitin@dsr-corporation.com>
Signed-off-by: Andrew Nikitin <andrew.nikitin@dsr-corporation.com>
Signed-off-by: Andrew Nikitin <andrew.nikitin@dsr-corporation.com>
Signed-off-by: Andrew Nikitin <andrew.nikitin@dsr-corporation.com>
Signed-off-by: Andrew Nikitin <andrew.nikitin@dsr-corporation.com>
Signed-off-by: Andrew Nikitin <andrew.nikitin@dsr-corporation.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.