INDY-1740: Fixed a bug in re-asking cancellation #933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
spivachuk
commented
Oct 3, 2018
spivachuk
commented
- Corrected the test of cancellation of scheduled re-asking for ledger statuses and maximal consistency proofs on reception of sufficient count of messages.
- Fixed cancellation of scheduled re-asking for ledger statuses and maximal consistency proofs which was not operable previously.
- Corrected the test of cancellation of scheduled re-asking for ledger statuses and maximal consistency proofs on reception of sufficient count of messages. Signed-off-by: Nikita Spivachuk <nikita.spivachuk@dsr-company.com>
- Fixed a bug in cancellation of scheduled re-asking for ledger statuses and maximal consistency proofs. Signed-off-by: Nikita Spivachuk <nikita.spivachuk@dsr-company.com>
| ledgerInfo = self.getLedgerInfoByType(ledger_id) | ||
| nodes = [node for node in self.owner.nodeReg if node not in ledgerInfo.ledgerStatusOk] | ||
| self.owner.request_ledger_status_from_nodes(ledger_id, nodes) | ||
|
|
||
| def reask_for_last_consistency_proof(self, ledger_id): | ||
| if ledger_id in self.request_consistency_proof_action_ids: |
There was a problem hiding this comment.
Is this condition really not needed?
There was a problem hiding this comment.
Made entry removal safe.
|
|
||
| def reask_for_ledger_status(self, ledger_id): | ||
| if ledger_id in self.request_ledger_status_action_ids: |
There was a problem hiding this comment.
Is this condition really not needed?
There was a problem hiding this comment.
Made entry removal safe.
- Corrected removal of action IDs from LedgerManager.request_ledger_status_action_ids and LedgerManager.request_consistency_proof_action_ids. Signed-off-by: Nikita Spivachuk <nikita.spivachuk@dsr-company.com>
sergey-shilov
approved these changes
Oct 3, 2018
andkononykhin
approved these changes
Oct 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.