Fixes for Python 3.6 support #957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Whitehead <andrew@1crm.com>
Signed-off-by: Andrew Whitehead <andrew@1crm.com>
|
Can one of the admins verify this patch? |
|
Could one of the committers please verify this patch? |
|
We need Python 3.6 CI/CD environment to make sure that all tests pass on Python 3.6 |
Signed-off-by: Andrew Whitehead <andrew@1crm.com>
|
@ashcherbakov Is there any timeline for adding a Python 3.6 testing environment? Without this change the library doesn't run at all on 3.6 and it's becoming increasingly difficult for us to support 3.5 (in von-network). |
|
@CyWolf We need to check with our Product, but I think it will be at the time of Ubuntu 18.04 support, which is scheduled at the end of this year - beginning of next year. |
|
Note: PR #974 includes these changes as well as Python 3.7 compatibility. |
|
(ci) test this please |
ashcherbakov
approved these changes
Aug 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prefer hashlib.sha3_256 when it's available (in python 3.6+) - the sha3 module is not compatible
Fix a type checking error that occurs in python 3.6+
This is an update of PR #714