Add GC-related metrics #968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
ashcherbakov
reviewed
Nov 8, 2018
| @@ -121,6 +120,25 @@ | |||
| logger = getlogger() | |||
|
|
|||
|
|
|||
| class GcTimeTracker: | |||
There was a problem hiding this comment.
How this can affect performance? Should we make this metrics disabled by default?
There was a problem hiding this comment.
Adding callback doesn't measurably affect performance. Asking for gc.get_objects() does add performance spikes once per 10 seconds, but only when there are already lots of objects, in which case we already have much bigger spikes from GC itself, so I don't think this is critical.
There was a problem hiding this comment.
On a second thought it's not hard to add checks if metrics are enabled, so I'll add them anyways.
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
ashcherbakov
approved these changes
Nov 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sergey Khoroshavin sergey.khoroshavin@dsr-corporation.com