INDY-1843: Discard pre-prepare with ordered request #990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
Toktar
commented
Nov 22, 2018
| @@ -1122,6 +1122,12 @@ def report_suspicious(reason): | |||
| "then the latest one - ignoring it".format(key)) | |||
| elif why_not == PP_CHECK_REQUEST_NOT_FINALIZED: | |||
| non_fin_reqs = self.nonFinalisedReqs(pre_prepare.reqIdr) | |||
| for req in non_fin_reqs: | |||
| if req not in self.requests and self.node.seqNoDB.get(req) != (None, None): | |||
There was a problem hiding this comment.
This should be discuss because it's not obviously for backup replicas.
Toktar
commented
Nov 22, 2018
plenum/server/replica.py
Outdated
| if req not in self.requests and self.node.seqNoDB.get(req) != (None, None): | ||
| self.logger.info("Request digest {} already ordered. Discard {} " | ||
| "from {}".format(req, pre_prepare, sender)) | ||
| report_suspicious(Suspicions.DUPLICATE_PPR_SENT) |
There was a problem hiding this comment.
Should it be DUPLICATE_PPR_SENT or a new suspicions PPR_WITH_ORDERED_REQUEST?
There was a problem hiding this comment.
I think PPR_WITH_ORDERED_REQUEST is better
|
What about repeated requests, which are finalized? (for example from previous ordered 3pc batch, before _gc called) |
|
@ArtObr We are not catch this problem in the fix. But it needs to solve, of course. |
plenum/test/replica/test_api.py
Outdated
|
|
||
|
|
||
| def test_process_pre_prepare_with_not_ordered_request(fake_node): |
There was a problem hiding this comment.
Should the test be called test_process_pre_prepare_with_ordered_request
…nto task-1843-not-request-ordered-txn
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
Signed-off-by: toktar <renata.toktar@dsr-corporation.com>
ashcherbakov
approved these changes
Nov 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If primary will include digest of already ordered request in pre-prepare message, then this pre-prepare will not be considered as faulty one and ordered request will be re-asked from every node.
For fix this bug added check for received pre-prepare message with not finalize request. Pre-prepare message will be discarded if one or more requests are already ordered.