This repository has been archived by the owner on Feb 29, 2024. It is now read-only.
Fixed git-scm download URL for Windows setup #1409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Herman <mwherman2000@hotmail.com>
mattraffel
suggested changes
Jan 16, 2019
There was a problem hiding this comment.
launch.json is windows specific. .netcore (and indy samples) are platform agnostic, as they should be. I'm feeling this file should not be included and developers should create/keep their own local copy of this file.
I suggest copying the contents of this file into the windows.md file as an example of what the launch.json would look like
mattraffel
previously approved these changes
Jan 16, 2019
|
@mwherman2000 can you fix the DCO requirement? |
Signed-off-by: Michael Herman <mwherman2000@hotmail.com>
|
Done ...wasn't aware the DCO had to be re-completed on each PR. Cheers |
mattraffel
approved these changes
Jan 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.