Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect arguments order passing in buildGetAttribRequest #204

Closed
mrlunin opened this issue Aug 10, 2023 · 0 comments
Closed

Incorrect arguments order passing in buildGetAttribRequest #204

mrlunin opened this issue Aug 10, 2023 · 0 comments

Comments

@mrlunin
Copy link

mrlunin commented Aug 10, 2023

I'm playing with Aries Framework Javascript agent.dids.import method and noticed that it's not possible to import some indy dids.

I receive always this error:

Error retrieving endpoints for did '53A4bb71Sja4VYqdKjuB7E' from ledger 'idunion' Request failed: client request invalid: InvalidClientRequest('validation error [ClientGetAttribOperation]: not a valid hash (needs to be in hex too) (hash=endpoint)',)

I think main issue of this in method buildGetAttribRequest here
https://github.com/hyperledger/indy-vdr/blob/main/wrappers/javascript/indy-vdr-react-native/cpp/indyVdr.cpp#L110

it passes arguments in the followign order: submitterDid, targetDid, hash, raw, etc

Actual definition of indy_vdr_build_get_attrib_request:

ErrorCode indy_vdr_build_get_attrib_request(FfiStr submitter_did,
                                            FfiStr target_did,
                                            FfiStr raw,
                                            FfiStr hash,
                                            FfiStr enc,
                                            RequestHandle *handle_p);

so, as I can ses raw goes to hash and hash goes to raw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants