fix(js): return body as string #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to prevent the reqId (which is a large number) from overflowing and changing Signed-off-by: Timo Glastra <timo@animo.id>
TimoGlastra
changed the title
Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
berendsliedrecht
previously approved these changes
Apr 11, 2023
berendsliedrecht
approved these changes
Apr 11, 2023
mirgee
pushed a commit
to mirgee/indy-vdr
that referenced
this pull request
May 10, 2023
Signed-off-by: Timo Glastra <timo@animo.id> Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to prevent the reqId (which is a large number) from overflowing and changing
We were running into this when implementing endorsement and needing to get the body of a request and send it to another agent. ACA-Py / the python wrapper als returns a string representation of the request when calling body