Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: maintenance update js wrapper #296

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

TimoGlastra
Copy link
Member

Updates the JS wrapper:

  • updates all deps to latest version
  • moves to pnpm, vitest, and biome
  • update wrapper version to 0.3.0-dev.0 (if everything works fine we can directly release 0.3.0)

Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
},
"dependencies": {
"@2060.io/ffi-napi": "4.0.9",
"@2060.io/ref-napi": "3.0.6",
"@hyperledger/indy-vdr-shared": "0.2.0-dev.6",
"@hyperledger/indy-vdr-shared": "workspace:*",
"@mapbox/node-pre-gyp": "^1.0.10",
"@types/ref-array-di": "^1.2.8",
"ref-array-di": "^1.2.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we update the binary to 0.4.3?

import { DID, setupPool } from './utils'

import { AcceptanceMechanismsRequest } from '@hyperledger/indy-vdr-nodejs'

console.log('hell')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

console statement here

"react": "18.2.0",
"react-native": "0.74.2",
"rimraf": "^5.0.7",
"typescript": "~5.4.5"
},
"peerDependencies": {
"react": ">= 16",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same thing here with the binary, I think it should be 0.4.3

@@ -0,0 +1,63 @@
0 silly argv {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this log file be committed?

@wadeking98
Copy link
Contributor

Also if it's not too much trouble do you mind incorporating the changes in from this PR? #270

Just the changes from these files:

  • wrappers/javascript/indy-vdr-nodejs/src/library/bindings.ts
  • wrappers/javascript/indy-vdr-nodejs/tests/IndyVdrTxnCache.test.ts
  • wrappers/javascript/indy-vdr-react-native/cpp/indyVdr.cpp
  • wrappers/javascript/indy-vdr-react-native/cpp/turboModuleUtility.cpp

otherwise I can do it in a separate PR if you'd prefer

@TimoGlastra
Copy link
Member Author

Also if it's not too much trouble do you mind incorporating the changes in from this PR? #270

Just the changes from these files:

  • wrappers/javascript/indy-vdr-nodejs/src/library/bindings.ts

  • wrappers/javascript/indy-vdr-nodejs/tests/IndyVdrTxnCache.test.ts

  • wrappers/javascript/indy-vdr-react-native/cpp/indyVdr.cpp

  • wrappers/javascript/indy-vdr-react-native/cpp/turboModuleUtility.cpp

otherwise I can do it in a separate PR if you'd prefer

Yes, will do!

@TimoGlastra
Copy link
Member Author

TimoGlastra commented Jun 12, 2024

@berendsliedrecht @andrewwhitehead any idea why the macOS build is suddenly failing? Only made changes to the JS wrapper

@wadeking98
Copy link
Contributor

wadeking98 commented Jun 14, 2024

@TimoGlastra not sure why it's just failing for the mac build, try updating time to 0.3.36 in the Cargo.toml file in libindy_vdr

berendsliedrecht and others added 2 commits June 17, 2024 16:53
Signed-off-by: Berend Sliedrecht <sliedrecht@berend.io>
Signed-off-by: Timo Glastra <timo@animo.id>
@TimoGlastra
Copy link
Member Author

Still failing sadly @berendsliedrecht

@TimoGlastra
Copy link
Member Author

Now sure what is happening with the segmentation vault now ... :/

@berendsliedrecht
Copy link
Contributor

@TimoGlastra could it be related to vitest?

@TimoGlastra
Copy link
Member Author

Yeah maybe 🤷 Haven't found the time to look into it yet :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants