Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] #96: Add a topic about permissions #100

Merged
merged 10 commits into from Aug 11, 2022
Merged

[docs] #96: Add a topic about permissions #100

merged 10 commits into from Aug 11, 2022

Conversation

outoftardis
Copy link
Contributor

@outoftardis outoftardis commented Aug 5, 2022 •
edited

Closes #96

@outoftardis
[docs] hyperledger#96: Add a topic about permissions
e851509 
Signed-off-by: Ekaterina Mekhnetsova <mekkatya@gmail.com>
@outoftardis
Remove log
8a6be7d 
Signed-off-by: Ekaterina Mekhnetsova <mekkatya@gmail.com>
@vercel
Copy link

vercel bot commented Aug 5, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
iroha-2-docs ✅ Ready (Inspect) Visit Preview Aug 9, 2022 at 9:23AM (UTC)

@outoftardis
Update intros
edec364 
Signed-off-by: Ekaterina Mekhnetsova <mekkatya@gmail.com>
@outoftardis
Fix formatting
3f4bdcc 
Signed-off-by: Ekaterina Mekhnetsova <mekkatya@gmail.com>
@outoftardis
Fix formatting
5073876 
Signed-off-by: Ekaterina Mekhnetsova <mekkatya@gmail.com>
@outoftardis
Copy link
Contributor Author

@Arjentix could you please review this new tutorial chapter about permissions?

Arjentix
Arjentix reviewed Aug 8, 2022
View reviewed changes
Copy link
Contributor

@Arjentix Arjentix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add a note, that permissions system will be rewritten soon (I think we will start this at autumn).

  • There will be no predefined tokens in Iroha 2. All tokens will be defined by users with Register instruction
  • There will be no predefined validators. All of them will be rewritten as WASM smart contracts. Probably they will be distributed with Iroha 2. Probably in another repository. We don't know now

src/guide/advanced/permissions.md Outdated Show resolved Hide resolved
src/guide/advanced/permissions.md Show resolved Hide resolved
src/guide/advanced/permissions.md Outdated Show resolved Hide resolved
src/guide/advanced/permissions.md Outdated Show resolved Hide resolved
src/guide/advanced/permissions.md Outdated Show resolved Hide resolved
src/guide/advanced/permissions.md Outdated Show resolved Hide resolved
src/guide/advanced/permissions.md Outdated Show resolved Hide resolved
@outoftardis
Copy link
Contributor Author

Please, add a note, that permissions system will be rewritten soon (I think we will start this at autumn).

  • There will be no predefined tokens in Iroha 2. All tokens will be defined by users with Register instruction
  • There will be no predefined validators. All of them will be rewritten as WASM smart contracts. Probably they will be distributed with Iroha 2. Probably in another repository. We don't know now

Ok, I'll add this note.
Predefined tokens are used in the LTS version, right? We are adding versioning to the tutorial, so we need to make sure that at least for the LTS version we have permissions documented.

@outoftardis
Address comments
6f6a279 
Signed-off-by: Ekaterina Mekhnetsova <mekkatya@gmail.com>
@outoftardis
Add examples
c61f0fe 
Signed-off-by: Ekaterina Mekhnetsova <mekkatya@gmail.com>
@outoftardis
Add a note
9b28fda 
Signed-off-by: Ekaterina Mekhnetsova <mekkatya@gmail.com>
@outoftardis
Copy link
Contributor Author

@Arjentix I've addressed your comments, please review

appetrosyan
appetrosyan reviewed Aug 9, 2022
View reviewed changes
src/guide/advanced/isi.md Outdated Show resolved Hide resolved
src/guide/advanced/isi.md Outdated Show resolved Hide resolved
src/guide/advanced/permissions.md Outdated Show resolved Hide resolved
@Arjentix
Copy link
Contributor

Arjentix commented Aug 9, 2022 •
edited

Predefined tokens are used in the LTS version, right? We are adding versioning to the tutorial, so we need to make sure that at least for the LTS version we have permissions documented.

Yes, they are used in the LTS

Arjentix
Arjentix approved these changes Aug 9, 2022
View reviewed changes
Copy link
Contributor

@Arjentix Arjentix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@outoftardis outoftardis requested a review from 6r1d as a code owner August 9, 2022 09:18
@outoftardis @appetrosyan
Apply suggestions from code review
13c8360 
Co-authored-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru>
Signed-off-by: Ekaterina Mekhnetsova <mekkatya@gmail.com>
@outoftardis
Fix formatting
6cc1aea 
Signed-off-by: Ekaterina Mekhnetsova <mekkatya@gmail.com>
@appetrosyan appetrosyan merged commit 5c55b86 into hyperledger:main Aug 11, 2022
This was referenced Aug 11, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appetrosyan appetrosyan appetrosyan approved these changes

@Arjentix Arjentix Arjentix approved these changes

@0x009922 0x009922 0x009922 approved these changes

@WRRicht3r WRRicht3r Awaiting requested review from WRRicht3r WRRicht3r is a code owner

@6r1d 6r1d Awaiting requested review from 6r1d

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documenting the permission types
4 participants
@outoftardis @Arjentix @appetrosyan @0x009922