Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] #301: render data model schema #303

Merged
merged 8 commits into from Apr 5, 2023
Merged

[feature] #301: render data model schema #303

merged 8 commits into from Apr 5, 2023

Conversation

0x009922
Copy link
Contributor

Resolves #301

@0x009922
[feature]: render schema from @iroha2/data-model-schema
94d11e7 
Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
@0x009922 0x009922 self-assigned this Mar 27, 2023
@vercel
Copy link

vercel bot commented Mar 27, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
iroha-2-docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 31, 2023 at 10:59AM (UTC)

@0x009922
[fix]: specify peer deps
ebda4c8 
Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
@0x009922 0x009922 changed the title [feature]: render data model schema [feature] #301: render data model schema Mar 27, 2023
6r1d
6r1d approved these changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@6r1d 6r1d left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far, ping me when you're making it a full PR

@outoftardis
Copy link
Contributor

can we render this not as a list?

image

I think what you had in the issue description looks better.

image

Otherwise looks good. We should also link to this page from the guide.

@0x009922
Copy link
Contributor Author

Just found that Iroha repo has schema in docs/source/reference, so it is easy to fetch it from GitHub, avoiding extraction through Action artifacts.

@0x009922 0x009922 mentioned this pull request Mar 31, 2023
Closed
@0x009922
[feature]: fetch schemas from GitHub
d0eaa2c 
Also move consts to `etc/meta.ts`

Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
@0x009922
[feature]: use dynamic routes
770949a 
Also bump dependencies

Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
@0x009922
[style]: don't use lists
2fe907e 
Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
@0x009922
Copy link
Contributor Author

I had to update packages in order to use dynamic routes feature.

@0x009922
[chore]: fix format
993e2a3 
Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
0x009922 and others added 2 commits March 31, 2023 17:58
@0x009922 @outoftardis
Update src/data-model-schema/[channel].paths.ts
8871e08 
Co-authored-by: Ekaterina Mekhnetsova <mekkatya@gmail.com>
Signed-off-by: 0x009922 <a.marcius26@gmail.com>
@0x009922
Merge branch 'main' into 301-iroha-schema
49ab2f5
@0x009922 0x009922 marked this pull request as ready for review March 31, 2023 10:59
outoftardis
outoftardis approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@outoftardis outoftardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@0x009922 0x009922 merged commit 19bbf59 into hyperledger:main Apr 5, 2023
4 checks passed
@0x009922 0x009922 deleted the 301-iroha-schema branch April 5, 2023 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@6r1d 6r1d 6r1d approved these changes

@outoftardis outoftardis outoftardis approved these changes

@WRRicht3r WRRicht3r WRRicht3r approved these changes

@appetrosyan appetrosyan Awaiting requested review from appetrosyan

Assignees

@0x009922 0x009922

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proposal: render Iroha schema as Markdown
4 participants
@0x009922 @outoftardis @6r1d @WRRicht3r