-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ESM/CJS problems #112
Merged
Merged
Fix ESM/CJS problems #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 0x009922 <a.marcius26@gmail.com>
Signed-off-by: 0x009922 <a.marcius26@gmail.com>
Signed-off-by: 0x009922 <a.marcius26@gmail.com>
Signed-off-by: 0x009922 <a.marcius26@gmail.com>
Signed-off-by: 0x009922 <a.marcius26@gmail.com>
Signed-off-by: 0x009922 <a.marcius26@gmail.com>
0x009922
added
iroha2
package: client
Related to Client package(-s)
package: data model
Related to Data Model package(-s)
package: crypto
Related to Crypto packages
labels
Jul 31, 2022
Signed-off-by: 0x009922 <a.marcius26@gmail.com>
Signed-off-by: 0x009922 <a.marcius26@gmail.com>
Signed-off-by: 0x009922 <a.marcius26@gmail.com>
Signed-off-by: 0x009922 <a.marcius26@gmail.com>
Signed-off-by: 0x009922 <a.marcius26@gmail.com>
Signed-off-by: 0x009922 <a.marcius26@gmail.com>
outoftardis
reviewed
Aug 8, 2022
outoftardis
reviewed
Aug 8, 2022
outoftardis
reviewed
Aug 8, 2022
0x009922
force-pushed
the
fix/esm-cjs-modules
branch
3 times, most recently
from
August 12, 2022 09:56
e50e38c
to
d644515
Compare
Signed-off-by: 0x009922 <a.marcius26@gmail.com>
Co-authored-by: Ekaterina Mekhnetsova <mekkatya@gmail.com> Signed-off-by: 0x009922 <a.marcius26@gmail.com>
Co-authored-by: Ekaterina Mekhnetsova <mekkatya@gmail.com> Signed-off-by: 0x009922 <a.marcius26@gmail.com>
Signed-off-by: 0x009922 <a.marcius26@gmail.com>
Signed-off-by: Ekaterina Mekhnetsova <mekkatya@gmail.com> Signed-off-by: 0x009922 <a.marcius26@gmail.com>
Co-authored-by: 0x009922 <a.marcius26@gmail.com> Signed-off-by: Ekaterina Mekhnetsova <mekkatya@gmail.com> Signed-off-by: 0x009922 <a.marcius26@gmail.com>
Signed-off-by: 0x009922 <a.marcius26@gmail.com>
0x009922
force-pushed
the
fix/esm-cjs-modules
branch
from
August 12, 2022 10:04
3bfda19
to
dfae06a
Compare
Signed-off-by: 0x009922 <a.marcius26@gmail.com>
outoftardis
reviewed
Aug 12, 2022
stefashkaa
approved these changes
Aug 15, 2022
outoftardis
approved these changes
Aug 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
iroha2
package: client
Related to Client package(-s)
package: crypto
Related to Crypto packages
package: data model
Related to Data Model package(-s)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of changes
Fix
@iroha2/crypto-target-web
→@iroha2/crypto-core
dependency - changedev
toprod
Define packages exports with
exports
field too. Also use.mjs
for ESM and.cjs
for CJS bundles.Drop API Extractor and esbuild. Use
rollup
for everything.API Extractor broke after moving to
tsconfig
paths monorepo approach. It was done to define actual packagesmain
/module
/exports
fields in theirpackage.json
. I moved to Rollup androllup-plugin-dts
.esbuild
doesn't eliminate dead code in case likeif (undefined)
- proof. It brokes in-source testing by Vitest. Thus, I moved again to Rollup.Drop
@iroha2/client-isomorphic-*
. Instead client library provides additional entrypoints for isomorphic adapters, like it is done atisomorphic-git
.For WebSocket, it has 2 entrypoints:
fetch
could be provided in the same way, but@iroha2/client
does not provide it by itself. There arenode-fetch
andundici
packages that could solve it:E2e tests - Migrate to Cypress 10