Skip to content

Commit

Permalink
Documentation update for setup and a small compile fix (#81)
Browse files Browse the repository at this point in the history
thanks!

This fix is very important, so I will merge it.

I'm sorry, there is not enough documents...
  • Loading branch information
lirm authored and MizukiSonoko committed Dec 8, 2016
1 parent 373eb2e commit b50117c
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 4 deletions.
17 changes: 15 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,8 @@ IROHA_HOME := iroha's root
## Requirement
```
cmake(3.5.2)
gRPC
LevelDB
```
## Recommended
Expand All @@ -194,9 +196,10 @@ fabric3 (python library, not hyperledger/fabric)
## Installation
```
$ git submodules init
$ git submodules update
$ git submodule init
$ git submodule update
$ mkdir build
$ cd build
$ cmake ..
$ make
```
Expand All @@ -206,6 +209,16 @@ or
$ fab deploy
```
(in local)
### Rebuilding gRPC stubs
This step should only be necessary if protobuf definitions changes, or version of gRPC or protoc has been updated.
(invoked from $IROHA_HOME)
```
protoc --cpp_out=core/infra/connection core/infra/connection/connection.proto
protoc --grpc_out=core/infra/connection --plugin=protoc-gen-grpc=`which grpc_cpp_plugin` core/infra/connection/connection.proto
```
## Authors
Expand Down
2 changes: 0 additions & 2 deletions core/validation/transaction_validator.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,6 @@ limitations under the License.

namespace transaction_validator {

using transaction::Transaction;

template<typename T>
bool isValid(const std::unique_ptr<T>& tx);

Expand Down

0 comments on commit b50117c

Please sign in to comment.