Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug potentially incorrect return Value in Kotlin SDK for FindAccountsByDomainId #1969

Closed
appetrosyan opened this issue Mar 11, 2022 · 5 comments
Assignees
Labels
Bug Something isn't working iroha2-dev The re-implementation of a BFT hyperledger in RUST

Comments

@appetrosyan
Copy link
Contributor

appetrosyan commented Mar 11, 2022

The result of executing FindAccountsByDomainId may sometimes return objects other than DomainId. U32 is returned as a Value, meaning that either the Kotlin SDK mishandles the datatype and converts it into a Value, or Iroha itself produces an incorrect data structure.

image.png

@appetrosyan appetrosyan added iroha2-dev The re-implementation of a BFT hyperledger in RUST Bug Something isn't working good first issue Good for newcomers and removed good first issue Good for newcomers labels Mar 11, 2022
appetrosyan added a commit to appetrosyan/iroha that referenced this issue Mar 16, 2022
…Vec` types.

Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru>
@mversic mversic changed the title Debug potentially incorrect return Value in Kotlin SDK for FindAccountsByDomainId Debug potentially incorrect return Value in Kotlin SDK for FindAccountsByDomainId Mar 23, 2022
@mversic mversic changed the title Debug potentially incorrect return Value in Kotlin SDK for FindAccountsByDomainId Debug potentially incorrect return Value in Kotlin SDK for FindAccountsByDomainId Mar 23, 2022
@mversic
Copy link
Contributor

mversic commented Mar 23, 2022

@arndey would it be possible to get unparsed query output? Just raw bytes so that I can confirm it was deserialized properly

@appetrosyan
Copy link
Contributor Author

Rebasing onto the release f58992e resolved the issue.

@appetrosyan appetrosyan mentioned this issue Mar 28, 2022
26 tasks
@mversic
Copy link
Contributor

mversic commented Mar 29, 2022

I'm still experiencing the exact same issue and it's not an SDK issue, the issue resides with Iroha

@mversic mversic reopened this Mar 29, 2022
@mversic
Copy link
Contributor

mversic commented Mar 29, 2022

the issue arises due to mismatch of compilation flags (namely roles flag) between server and client when compilation flags affect inclusion/exclusion of the fields/variants of data model structures.

Best course of action is to remove conditional layout of data model structures altogether and have clients support all features while server should reject request it cannot fulfill

@mversic
Copy link
Contributor

mversic commented Mar 29, 2022

server should be able to generate a valid response to any request regardless of which feature flag it was compiled with, though it may not be able to fulfill the incoming request

appetrosyan added a commit to appetrosyan/iroha that referenced this issue Mar 29, 2022
…feature set.

Signed-off-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru>
appetrosyan added a commit to appetrosyan/iroha that referenced this issue Mar 29, 2022
…feature set.

Signed-off-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru>
appetrosyan added a commit that referenced this issue Mar 30, 2022
Signed-off-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

No branches or pull requests

3 participants