Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce sorted collections to schemas #2114

Closed
mversic opened this issue Apr 17, 2022 · 0 comments
Closed

Introduce sorted collections to schemas #2114

mversic opened this issue Apr 17, 2022 · 0 comments
Assignees
@mversic
Labels
api-changes Changes in the API for client libraries Bug Something isn't working iroha2-dev The re-implementation of a BFT hyperledger in RUST

Comments

@mversic
Copy link
Contributor

mversic commented Apr 17, 2022 •
edited

BTreeMap/BTreeSet when serialized must have a defined ordering. There was a bug recently because BTreeMap was represented as an unordered collection, i.e. HashMap because schemas file didn't carry information on the ordering of elements.

Vectors and arrays can also have a defined ordering. For sorted vectors this means that sdk developers can deserialize them into e.g. HashSet as long as this HashSets is serialized/deserialized into sorted vector. Arrays can therefore be serialized/deserialized into static HashSet
@mversic mversic added Bug Something isn't working iroha2-dev The re-implementation of a BFT hyperledger in RUST api-changes Changes in the API for client libraries labels Apr 17, 2022
@mversic mversic self-assigned this Apr 17, 2022
@mversic mversic mentioned this issue Apr 17, 2022
Merged
@mversic mversic changed the title Introduce SortedVec to schemas Introduce sorted collections to schemas Apr 17, 2022
appetrosyan pushed a commit that referenced this issue Apr 20, 2022
@mversic
[schema] #2114: Sorted collections support in schemas (#2115)
a13ec4c
@mversic mversic closed this as completed Apr 20, 2022
mversic added a commit to mversic/iroha that referenced this issue May 2, 2022
@mversic
[schema] hyperledger#2114: Sorted collections support in schemas (hyp…
b820a0d 
…erledger#2115)

Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
appetrosyan pushed a commit to appetrosyan/iroha that referenced this issue May 4, 2022
@mversic @appetrosyan
[schema] hyperledger#2114: Sorted collections support in schemas (hyp…
313c0c5 
…erledger#2115)
appetrosyan pushed a commit to appetrosyan/iroha that referenced this issue May 12, 2022
@mversic @appetrosyan
[schema] hyperledger#2114: Sorted collections support in schemas (hyp…
bf75b49 
…erledger#2115)
appetrosyan pushed a commit to appetrosyan/iroha that referenced this issue May 12, 2022
@mversic @appetrosyan
[schema] hyperledger#2114: Sorted collections support in schemas (hyp…
275138d 
…erledger#2115)
appetrosyan pushed a commit to appetrosyan/iroha that referenced this issue May 12, 2022
@mversic @appetrosyan
[schema] hyperledger#2114: Sorted collections support in schemas (hyp…
11e659f 
…erledger#2115)
appetrosyan pushed a commit to appetrosyan/iroha that referenced this issue May 12, 2022
@mversic @appetrosyan
[schema] hyperledger#2114: Sorted collections support in schemas (hyp…
02e233f 
…erledger#2115)
appetrosyan pushed a commit to appetrosyan/iroha that referenced this issue May 12, 2022
@mversic @appetrosyan
[schema] hyperledger#2114: Sorted collections support in schemas (hyp…
654ca7c 
…erledger#2115)
appetrosyan pushed a commit to appetrosyan/iroha that referenced this issue May 12, 2022
@mversic @appetrosyan
[schema] hyperledger#2114: Sorted collections support in schemas (hyp…
fbe7c56 
…erledger#2115)

Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
mversic added a commit to mversic/iroha that referenced this issue May 13, 2022
@mversic
[schema] hyperledger#2114: Sorted collections support in schemas (hyp…
3b0487e 
…erledger#2115)

Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
mversic added a commit to mversic/iroha that referenced this issue May 13, 2022
@mversic
[schema] hyperledger#2114: Sorted collections support in schemas (hyp…
1c95912 
…erledger#2115)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mversic mversic

Labels
api-changes Changes in the API for client libraries Bug Something isn't working iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mversic