Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make client transport-agnostic: WebSocket, events #2145

Closed
0x009922 opened this issue Apr 25, 2022 · 0 comments · Fixed by #2146
Closed

Make client transport-agnostic: WebSocket, events #2145

0x009922 opened this issue Apr 25, 2022 · 0 comments · Fixed by #2146
Assignees
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST Refactor Improvement to overall code quality

Comments

@0x009922
Copy link
Contributor

0x009922 commented Apr 25, 2022

Make it possible to use iroha_client with custom WebSocket transport implementation. Provide functional abstractions to handle WebSocket flow. Refactor current Events API implementation to use these abstractions.

@0x009922 0x009922 added iroha2-dev The re-implementation of a BFT hyperledger in RUST Refactor Improvement to overall code quality labels Apr 25, 2022
@0x009922 0x009922 self-assigned this Apr 26, 2022
0x009922 added a commit to 0x009922/iroha that referenced this issue Apr 28, 2022
Signed-off-by: 0x009922 <a.marcius26@gmail.com>
0x009922 added a commit to 0x009922/iroha that referenced this issue May 6, 2022
Signed-off-by: 0x009922 <a.marcius26@gmail.com>
0x009922 added a commit to 0x009922/iroha that referenced this issue May 11, 2022
Signed-off-by: 0x009922 <a.marcius26@gmail.com>
0x009922 added a commit to 0x009922/iroha that referenced this issue May 17, 2022
Signed-off-by: 0x009922 <a.marcius26@gmail.com>
0x009922 added a commit that referenced this issue May 17, 2022
Signed-off-by: 0x009922 <a.marcius26@gmail.com>
appetrosyan pushed a commit that referenced this issue May 19, 2022
…ta logic (#2146)

* feat: impl ws transport-agnostic design

Signed-off-by: 0x009922 <a.marcius26@gmail.com>

* refactor: remove unnecessary options

Signed-off-by: 0x009922 <a.marcius26@gmail.com>

* refactor: update struct names, add docs, chores

Signed-off-by: 0x009922 <a.marcius26@gmail.com>

* lint: fix errors

Signed-off-by: 0x009922 <a.marcius26@gmail.com>

* fix: add clone derives as well

Signed-off-by: 0x009922 <a.marcius26@gmail.com>

* [refactor]: optimize inlining; chores

Signed-off-by: 0x009922 <a.marcius26@gmail.com>

* [refactor] #2145: remove unused mut

Signed-off-by: 0x009922 <a.marcius26@gmail.com>

* [refactor]: remove more unused muts

Signed-off-by: 0x009922 <a.marcius26@gmail.com>

* [refactor]: hide implementation details

Signed-off-by: 0x009922 <a.marcius26@gmail.com>

* [refactor] apply suggestions from code review

Signed-off-by: 0x009922 <a.marcius26@gmail.com>

* [refactor]: make solution clearer; update `RequestBuilder`

Signed-off-by: 0x009922 <a.marcius26@gmail.com>

* [documentation] #2145: fix links at doc comments

Signed-off-by: 0x009922 <a.marcius26@gmail.com>

* Update client/src/http.rs

Co-authored-by: Daniil <arjentix@gmail.com>

Signed-off-by: 0x009922 <a.marcius26@gmail.com>

* [documentation] #2145: update links in doccomments

Signed-off-by: 0x009922 <a.marcius26@gmail.com>

* [fix] #2145: fix previous merge

Signed-off-by: 0x009922 <a.marcius26@gmail.com>

* Merge branch 'iroha2-dev' into task/2145/refactor-client-ws

Signed-off-by: 0x009922 <a.marcius26@gmail.com>
pesterev pushed a commit to pesterev/iroha that referenced this issue May 25, 2022
…act pure data logic (hyperledger#2146)

* feat: impl ws transport-agnostic design

Signed-off-by: 0x009922 <a.marcius26@gmail.com>

* refactor: remove unnecessary options

Signed-off-by: 0x009922 <a.marcius26@gmail.com>

* refactor: update struct names, add docs, chores

Signed-off-by: 0x009922 <a.marcius26@gmail.com>

* lint: fix errors

Signed-off-by: 0x009922 <a.marcius26@gmail.com>

* fix: add clone derives as well

Signed-off-by: 0x009922 <a.marcius26@gmail.com>

* [refactor]: optimize inlining; chores

Signed-off-by: 0x009922 <a.marcius26@gmail.com>

* [refactor] hyperledger#2145: remove unused mut

Signed-off-by: 0x009922 <a.marcius26@gmail.com>

* [refactor]: remove more unused muts

Signed-off-by: 0x009922 <a.marcius26@gmail.com>

* [refactor]: hide implementation details

Signed-off-by: 0x009922 <a.marcius26@gmail.com>

* [refactor] apply suggestions from code review

Signed-off-by: 0x009922 <a.marcius26@gmail.com>

* [refactor]: make solution clearer; update `RequestBuilder`

Signed-off-by: 0x009922 <a.marcius26@gmail.com>

* [documentation] hyperledger#2145: fix links at doc comments

Signed-off-by: 0x009922 <a.marcius26@gmail.com>

* Update client/src/http.rs

Co-authored-by: Daniil <arjentix@gmail.com>

Signed-off-by: 0x009922 <a.marcius26@gmail.com>

* [documentation] hyperledger#2145: update links in doccomments

Signed-off-by: 0x009922 <a.marcius26@gmail.com>

* [fix] hyperledger#2145: fix previous merge

Signed-off-by: 0x009922 <a.marcius26@gmail.com>

* Merge branch 'iroha2-dev' into task/2145/refactor-client-ws

Signed-off-by: 0x009922 <a.marcius26@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST Refactor Improvement to overall code quality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants