Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When genesis transaction has too many isi, Iroha prints meaningless message #2232

Closed
0x009922 opened this issue May 19, 2022 · 1 comment
Closed

When genesis transaction has too many isi, Iroha prints meaningless message #2232

0x009922 opened this issue May 19, 2022 · 1 comment
Assignees
@Arjentix
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST

Comments

@0x009922
Copy link
Contributor

Description

I've generated sample genesis files with different sizes. It turned out that starting from ~1425..1437 count of ISI Iroha doesn't accept genesis.

Expected

Expected genesis to be submitted or rejected with a message like "Your genesis transaction has too many instructions"

Actual

2022-05-19T08:18:35.088297Z ERROR iroha_core::sumeragi::fault: Failed to submit genesis transactions error=Genesis transactions set is empty.

Additional details

Sample genesis with 1437 isi: https://pastebin.com/d0GbajXZ
@0x009922 0x009922 added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label May 19, 2022
@0x009922
Copy link
Contributor Author

Another case:

  • Genesis has 5 transactions;
  • Each transaction has ~1010 isi

Iroha accepts it.

@Arjentix Arjentix self-assigned this May 19, 2022
@Arjentix Arjentix mentioned this issue May 19, 2022
Merged
Arjentix added a commit that referenced this issue May 20, 2022
@Arjentix
[fix] #2232: Make Iroha print meaningful message when genesis has too…
49407ff 
… many isi (#2239)

Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
pesterev pushed a commit to pesterev/iroha that referenced this issue May 25, 2022
@Arjentix @pesterev
[fix] hyperledger#2232: Make Iroha print meaningful message when gene…
3428661 
…sis has too many isi (hyperledger#2239)

Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Arjentix Arjentix

Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@appetrosyan @Arjentix @0x009922