Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Pytest framework thin wrapper around client_cli #3633

Open
appetrosyan opened this issue Jun 21, 2023 · 0 comments
Open

Make Pytest framework thin wrapper around client_cli #3633

appetrosyan opened this issue Jun 21, 2023 · 0 comments
Labels
good first issue Good for newcomers iroha2-dev The re-implementation of a BFT hyperledger in RUST Refactor Improvement to overall code quality

Comments

@appetrosyan
Copy link
Contributor

appetrosyan commented Jun 21, 2023

I don't think we need yet another level of abstraction over client_cli:

  1. no need to learn yet another framework to write a test
  2. makes you more familiar with iroha_client_cli API
  3. nothing is obfuscated away
  4. we should be focusing on implementing missing functionality in iroha_client_cli

All we need is a way to parse output, we don't need a way to construct the input

_Originally posted by @mversic in
#3490

@appetrosyan appetrosyan changed the title However, I think that this could be done as a separate ticket. Make Pytest framework thin wrapper around client_cli Jun 26, 2023
@appetrosyan appetrosyan added iroha2-dev The re-implementation of a BFT hyperledger in RUST Refactor Improvement to overall code quality good first issue Good for newcomers labels Jun 26, 2023
@mversic mversic self-assigned this Oct 9, 2023
@mversic mversic removed their assignment Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers iroha2-dev The re-implementation of a BFT hyperledger in RUST Refactor Improvement to overall code quality
Projects
None yet
Development

No branches or pull requests

2 participants