-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] #3376: Add Iroha Client CLI pytest automation framework #3490
[feature] #3376: Add Iroha Client CLI pytest automation framework #3490
Conversation
Codecov Report
@@ Coverage Diff @@
## iroha2-dev #3490 +/- ##
==============================================
- Coverage 62.33% 56.03% -6.30%
==============================================
Files 169 160 -9
Lines 31218 31294 +76
==============================================
- Hits 19459 17535 -1924
- Misses 11759 13759 +2000
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we can test SDKs with this framework.
For example, I could create a JavaScript CLI (using iroha-javascript) with the same interface as
iroha_client_clihas. Then it would be straightforward to plug it into
client_cli.py`, passing just a different binary path.
First of all, it will ensure that JS or whatever SDK covers the same functionality for sure. Furthermore, building such a CLI using JS SDK will help to enhance the SDK itself, because it still doesn't have "real-word" use cases.
I have number of failed tests when i try to run testing suit. |
@astrokov7 do we need to restart iroha before running tests? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general.
no |
de7fb5e
to
9d4826a
Compare
7cce0c0
to
648ad7e
Compare
648ad7e
to
13813a2
Compare
In the inteerest of time preservation it's better to fix this upstream.
…ramework Signed-off-by: alexstroke <busyfifer@gmail.com>
…/pytests Signed-off-by: alexstroke <busyfifer@gmail.com>
Signed-off-by: alexstroke <busyfifer@gmail.com>
Signed-off-by: alexstroke <busyfifer@gmail.com>
Signed-off-by: alexstroke <busyfifer@gmail.com>
Signed-off-by: alexstroke <busyfifer@gmail.com>
Signed-off-by: alexstroke <busyfifer@gmail.com>
Signed-off-by: alexstroke <busyfifer@gmail.com>
Signed-off-by: alexstroke <busyfifer@gmail.com>
Signed-off-by: alexstroke <busyfifer@gmail.com>
Signed-off-by: alexstroke <busyfifer@gmail.com>
Signed-off-by: alexstroke <busyfifer@gmail.com>
Signed-off-by: alexstroke <busyfifer@gmail.com>
Signed-off-by: alexstroke <busyfifer@gmail.com>
13813a2
to
6e57793
Compare
Description
This PR introduces automated tests for the Iroha Client CLI, using Python's Pytest framework. The new test suite includes a collection of tests that verify the functionality of the client CLI in various scenarios.