Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

where to put genesis.json and executor.wasm? #4320

Open
mversic opened this issue Feb 23, 2024 · 2 comments
Open

where to put genesis.json and executor.wasm? #4320

mversic opened this issue Feb 23, 2024 · 2 comments
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST question Further information is requested

Comments

@mversic
Copy link
Contributor

mversic commented Feb 23, 2024

          I am not sure moving this is correct... A lot of other stuff expects to find `executor.wasm` (and `genesis.json`) there. I think this is why some of the consistency and all the integration tests are failing..

Originally posted by @DCNick3 in #4304 (comment)

@mversic mversic added question Further information is requested iroha2-dev The re-implementation of a BFT hyperledger in RUST labels Feb 23, 2024
@0x009922 0x009922 changed the title where to put genesis.json and executor.json? where to put genesis.json and executor.wasm? Feb 25, 2024
@0x009922
Copy link
Contributor

I moved it to the same directory with docker-compose files to reduce confusion.

There are indeed tests relying on these files, but I considered this coupling as secondary, while being docker-compose configurations as primary. If it is not the case, then, imo, there should be dedicated config files for docker-compose configurations not related to tests. Mixing both worlds is slippery.

@mversic
Copy link
Contributor Author

mversic commented Feb 26, 2024

Mixing both worlds is slippery

I very much agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants