Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] #4303: Fix Docker Compose path for tests #4304

Merged

Conversation

BAStos525
Copy link
Member

@BAStos525 BAStos525 commented Feb 20, 2024

Description

Fix Docker Compose path for tests after #4239 merge.

Linked issue

#4303

Closes #4303

Benefits

Make available to run Docker Compose files tests before image pushing.

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

@github-actions github-actions bot added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Feb 20, 2024
@BAStos525 BAStos525 self-assigned this Feb 20, 2024
@BAStos525 BAStos525 added the CI label Feb 20, 2024
@coveralls
Copy link
Collaborator

coveralls commented Feb 20, 2024

Pull Request Test Coverage Report for Build 7979306273

Details

  • -4 of 4 (0.0%) changed or added relevant lines in 1 file are covered.
  • 2964 unchanged lines in 53 files lost coverage.
  • Overall coverage decreased (-0.3%) to 56.507%

Changes Missing Coverage Covered Lines Changed/Added Lines %
core/test_network/src/lib.rs 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
core/src/sumeragi/network_topology.rs 1 98.78%
tools/kagami/src/crypto.rs 1 12.12%
data_model/src/metadata.rs 2 78.87%
primitives/src/unique_vec.rs 2 91.24%
config/src/kura.rs 3 80.0%
config/src/logger.rs 5 72.73%
logger/src/lib.rs 5 94.12%
tools/kagami/src/main.rs 5 0.0%
crypto/src/signature/secp256k1.rs 7 96.09%
telemetry/src/dev.rs 7 0.0%
Totals Coverage Status
Change from base Build 7884695009: -0.3%
Covered Lines: 22413
Relevant Lines: 39664

💛 - Coveralls

0x009922
0x009922 previously approved these changes Feb 20, 2024
Signed-off-by: BAStos525 <jungle.vas@yandex.ru>
Copy link
Contributor

@6r1d 6r1d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as-is as Vasily requested

@mversic mversic merged commit 70f4114 into hyperledger:iroha2-dev Feb 23, 2024
2 checks passed
@BAStos525 BAStos525 deleted the fix/docker-compose-CI-path branch February 23, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants