Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update the contributing guide #4634

Merged
merged 1 commit into from
May 27, 2024
Merged

docs: update the contributing guide #4634

merged 1 commit into from
May 27, 2024

Conversation

MukulKolpe
Copy link
Contributor

@MukulKolpe MukulKolpe commented May 21, 2024 •
edited

Description

Updated the contributing guide with reference to issues #4502, #4501, #4433.

Linked issue

Closes #4585

Benefits

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

nxsaken
nxsaken requested changes May 22, 2024
View reviewed changes
Copy link
Contributor

@nxsaken nxsaken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thank you for the PR! I left some comments

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@MukulKolpe MukulKolpe force-pushed the contributing_guide branch 2 times, most recently from 7913454 to 31b2cb0 Compare May 22, 2024 09:50
@MukulKolpe MukulKolpe requested a review from nxsaken May 22, 2024 09:52
nxsaken
nxsaken reviewed May 22, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@MukulKolpe
Copy link
Contributor Author

Thanks, @nxsaken!

@MukulKolpe @nxsaken
docs: update the contributing guide
94223b0 
Signed-off-by: Mukul Kolpe <mukulkolpe45@gmail.com>
@nxsaken nxsaken merged commit 7b51419 into hyperledger:main May 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nxsaken nxsaken nxsaken approved these changes

@s8sato s8sato Awaiting requested review from s8sato s8sato is a code owner

@mversic mversic Awaiting requested review from mversic mversic is a code owner

@SamHSmith SamHSmith Awaiting requested review from SamHSmith SamHSmith is a code owner

@outoftardis outoftardis Awaiting requested review from outoftardis outoftardis is a code owner

@Erigara Erigara Awaiting requested review from Erigara Erigara is a code owner

@0x009922 0x009922 Awaiting requested review from 0x009922 0x009922 is a code owner

@DCNick3 DCNick3 Awaiting requested review from DCNick3 DCNick3 is a code owner

@VAmuzing VAmuzing Awaiting requested review from VAmuzing

@Asem-Abdelhady Asem-Abdelhady Awaiting requested review from Asem-Abdelhady

@dima74 dima74 Awaiting requested review from dima74 dima74 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update the contributing guide
2 participants
@MukulKolpe @nxsaken