Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace iroha2 with iroha1 labels #4501

Closed
mversic opened this issue Apr 23, 2024 · 2 comments
Closed

Replace iroha2 with iroha1 labels #4501

mversic opened this issue Apr 23, 2024 · 2 comments
Assignees
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST

Comments

@mversic
Copy link
Contributor

mversic commented Apr 23, 2024

Since we made iroha2 into main branch, I think we should remove iroha2 labels and create iroha1 labels. We will no longer tag new issues/PRs with iroha2 label if they are targeting main branch, but we will tag issues/PRs with iroha1 if they are targeting iroha1-main

Suggestion:

  1. create new label iroha1
  2. tag all issues/PRs related to iroha1 with iroha1 label
  3. delete iroha2 label

this should be done in github and zenhub

@mversic mversic added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Apr 23, 2024
@s8sato
Copy link
Contributor

s8sato commented Apr 23, 2024

Just a thought, but for step 2, the following may be worth trying in an experimental repository:

gh [issue|pr] list --search "-label:iroha2" | (extract numbers) | xargs -I {} gh [issue|pr] edit {} --add-label "iroha1"

https://cli.github.com/manual/gh

nxsaken added a commit to nxsaken/iroha that referenced this issue Apr 30, 2024
…roha1`

Signed-off-by: Nurzhan Sakén <nurzhan.sakenov@gmail.com>
nxsaken added a commit to nxsaken/iroha that referenced this issue Apr 30, 2024
Signed-off-by: Nurzhan Sakén <nurzhan.sakenov@gmail.com>
nxsaken added a commit to nxsaken/iroha that referenced this issue Apr 30, 2024
Signed-off-by: Nurzhan Sakén <nurzhan.sakenov@gmail.com>
mversic pushed a commit to nxsaken/iroha that referenced this issue Apr 30, 2024
Signed-off-by: Nurzhan Sakén <nurzhan.sakenov@gmail.com>
nxsaken added a commit that referenced this issue May 1, 2024
Signed-off-by: Nurzhan Sakén <nurzhan.sakenov@gmail.com>
nxsaken added a commit to nxsaken/iroha that referenced this issue May 1, 2024
Signed-off-by: Nurzhan Sakén <nurzhan.sakenov@gmail.com>
nxsaken added a commit that referenced this issue May 2, 2024
[ci] #4501: Set up PR labeler for I1

Signed-off-by: Nurzhan Sakén <nurzhan.sakenov@gmail.com>
@nxsaken
Copy link
Contributor

nxsaken commented May 2, 2024

Instead of deleting the iroha2 label, I renamed it to iroha2-dev. It shouldn't be used anymore: assume that new unlabeled issues/PRs are related to Iroha 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

No branches or pull requests

4 participants