Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed docker build arguments format #1068

Merged

Conversation

rkharisov
Copy link

@rkharisov rkharisov commented Jun 10, 2021

Description of the Change

  1. Changed format of docker build arguments
  2. Removed outdated config 'TORII_CONNECT_URL' from test configurations

Benefits

Possible Drawbacks

Usage Examples or Tests [optional]

Alternate Designs [optional]

Signed-off-by: rkharisov <rinat@soramitsu.co.jp>
@rkharisov rkharisov force-pushed the fix/github-actions-build-args branch from ea7d1ae to ae6177f Compare June 10, 2021 10:46
@github-actions github-actions bot added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Jun 10, 2021
@codecov
Copy link

codecov bot commented Jun 10, 2021

Codecov Report

Merging #1068 (ae6177f) into iroha2-dev (13d6694) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           iroha2-dev    #1068      +/-   ##
==============================================
- Coverage       70.04%   70.02%   -0.03%     
==============================================
  Files              76       76              
  Lines           12066    12066              
==============================================
- Hits             8452     8449       -3     
- Misses           3614     3617       +3     
Impacted Files Coverage Δ
iroha/src/block_sync.rs 86.12% <0.00%> (-1.16%) ⬇️
iroha/src/sumeragi.rs 91.84% <0.00%> (-0.10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13d6694...ae6177f. Read the comment docs.

@rkharisov rkharisov marked this pull request as ready for review June 10, 2021 11:20
@rkharisov rkharisov merged commit 898e6e9 into hyperledger:iroha2-dev Jun 10, 2021
@rkharisov rkharisov deleted the fix/github-actions-build-args branch June 10, 2021 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants