Fix add_peer_test #1408
Merged
Fix add_peer_test #1408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kuvaldini
commented
Sep 6, 2021
•
kuvaldini
commented
- Fix race condition in add_peer_test
- small refactotign
- [refac] report_abort() to protp_tx_resp.cpp
Signed-off-by: kuvaldini <ivan@kuvaldini.pro>
/build all Signed-off-by: kuvaldini <ivan@kuvaldini.pro>
/build all Signed-off-by: kuvaldini <ivan@kuvaldini.pro>
/build all Signed-off-by: kuvaldini <ivan@kuvaldini.pro>
/build all Signed-off-by: kuvaldini <ivan@kuvaldini.pro>
iceseer
reviewed
Sep 8, 2021
shared_model/backend/protobuf/transaction_responses/impl/proto_tx_response.cpp
Outdated
Show resolved
Hide resolved
iceseer
reviewed
Sep 8, 2021
test/framework/integration_framework/integration_test_framework.hpp
Outdated
Show resolved
Hide resolved
iceseer
reviewed
Sep 8, 2021
test/framework/integration_framework/integration_test_framework.cpp
Outdated
Show resolved
Hide resolved
test/framework/integration_framework/integration_test_framework.cpp
Outdated
Show resolved
Hide resolved
iceseer
reviewed
Sep 8, 2021
test/framework/integration_framework/integration_test_framework.cpp
Outdated
Show resolved
Hide resolved
/build all Signed-off-by: kuvaldini <ivan@kuvaldini.pro>
/build all Signed-off-by: kuvaldini <ivan@kuvaldini.pro>
Signed-off-by: kuvaldini <ivan@kuvaldini.pro>
/build all Signed-off-by: kuvaldini <ivan@kuvaldini.pro>
/build all Signed-off-by: kuvaldini <ivan@kuvaldini.pro>
/build all Signed-off-by: kuvaldini <ivan@kuvaldini.pro>
/build all Signed-off-by: kuvaldini <ivan@kuvaldini.pro>
/build all Signed-off-by: kuvaldini <ivan@kuvaldini.pro>
/build all Signed-off-by: kuvaldini <ivan@kuvaldini.pro>
/build all Signed-off-by: kuvaldini <ivan@kuvaldini.pro>
/build all Signed-off-by: kuvaldini <ivan@kuvaldini.pro>
/build all Signed-off-by: kuvaldini <ivan@kuvaldini.pro>
/build all Signed-off-by: kuvaldini <ivan@kuvaldini.pro>
/build all Signed-off-by: kuvaldini <ivan@kuvaldini.pro>
/build all Signed-off-by: kuvaldini <ivan@kuvaldini.pro>
/build all Signed-off-by: kuvaldini <ivan@kuvaldini.pro>
/build all Signed-off-by: kuvaldini <ivan@kuvaldini.pro>
/build all Signed-off-by: kuvaldini <ivan@kuvaldini.pro>
/build all Signed-off-by: kuvaldini <ivan@kuvaldini.pro>
/build all Signed-off-by: kuvaldini <ivan@kuvaldini.pro>
/build all Signed-off-by: kuvaldini <ivan@kuvaldini.pro>
This reverts commit 4325647.
/build all Signed-off-by: kuvaldini <ivan@kuvaldini.pro>
iceseer
approved these changes
Sep 17, 2021
kamilsa
approved these changes
Sep 17, 2021
/build all Signed-off-by: kuvaldini <ivan@kuvaldini.pro>
Closed
iceseer
pushed a commit
that referenced
this pull request
Nov 12, 2021
* Fix race condition in add_peer_test * REFACTORED add_peer_test * fake peer reuse port [does not properly with grpc] * small refactoring * [refac] report_abort() to protp_tx_resp.cpp * [gha] runs-on: ubuntu-20.04 * [GHA] ctest log groups * [gha] ctest no --repeat until-pass:3 * [FIXME] skip test port_guard Signed-off-by: kuvaldini <ivan@kuvaldini.pro>
kuvaldini
added a commit
that referenced
this pull request
Nov 12, 2021
* Fix race condition in add_peer_test * REFACTORED add_peer_test * fake peer reuse port [does not properly with grpc] * small refactoring * [refac] report_abort() to protp_tx_resp.cpp * [gha] runs-on: ubuntu-20.04 * [GHA] ctest log groups * [gha] ctest no --repeat until-pass:3 * [FIXME] skip test port_guard Signed-off-by: kuvaldini <47349143+kuvaldini@users.noreply.github.com>
baziorek
pushed a commit
to petermetz/iroha
that referenced
this pull request
Dec 28, 2021
* Fix race condition in add_peer_test * REFACTORED add_peer_test * fake peer reuse port [does not properly with grpc] * small refactoring * [refac] report_abort() to protp_tx_resp.cpp * [gha] runs-on: ubuntu-20.04 * [GHA] ctest log groups * [gha] ctest no --repeat until-pass:3 * [FIXME] skip test port_guard Signed-off-by: kuvaldini <47349143+kuvaldini@users.noreply.github.com> Signed-off-by: G.Bazior <bazior@agh.edu.pl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.