Replace iroha_error with thiserror and eyre #1429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KalitaAlexey
requested review from
e-ivkov,
i1i1,
Revertron and
rkharisov
as code owners
|
You have to also sign the commit properly - check the DCO CI check info. |
KalitaAlexey
force-pushed
the
migrate-to-thiserror
branch
from
878fd6a
to
b401d8f
Compare
github-actions
bot
added
the
iroha2-dev
i1i1
suggested changes
Sep 13, 2021
KalitaAlexey
force-pushed
the
migrate-to-thiserror
branch
from
b401d8f
to
c0a7732
Compare
i1i1
reviewed
Sep 15, 2021
KalitaAlexey
force-pushed
the
migrate-to-thiserror
branch
2 times, most recently
from
1ff39ec
to
93bc57a
Compare
i1i1
previously approved these changes
Sep 15, 2021
KalitaAlexey
force-pushed
the
migrate-to-thiserror
branch
from
93bc57a
to
ce6a0ce
Compare
Signed-off-by: Alexey Kalita <kalita.alexey@outlook.com> Signed-off-by: i1i1 <vanyarybin1@live.ru>
i1i1
force-pushed
the
migrate-to-thiserror
branch
from
ce6a0ce
to
84a2387
Compare
e-ivkov
approved these changes
Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
iroha_error is a crate that contained means to make it easier to make a custom error and to create chains of errors.
This code is almost identical to crates thiserror and eyre.
Issue
Resolves #1223
Benefits
Replacing iroha_error with thiserror and eyre reduces burden and increases stability.
Possible Drawbacks
None
Usage Examples or Tests
iroha/src/tx.rs (transaction_not_accepted) is changed