Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconnect telemetry #1574

Merged

Conversation

KalitaAlexey
Copy link

@KalitaAlexey KalitaAlexey commented Nov 2, 2021

Signed-off-by: Alexey Kalita kalita.alexey@outlook.com

Description of the Change

If telemetry fails to send a message, the node is going to reconnect in a few seconds.
While the telemetry is down, messages are skipped.
The period between reconnects can be customized with MIN_PERIOD and MAX_POWER

Issue

Closes #1546

Benefits

Possible Drawbacks

Usage Examples or Tests [optional]

Alternate Designs [optional]

@github-actions github-actions bot added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Nov 2, 2021
@codecov
Copy link

codecov bot commented Nov 2, 2021

Codecov Report

Merging #1574 (b817543) into iroha2-dev (fd84c85) will decrease coverage by 0.18%.
The diff coverage is 90.65%.

Impacted file tree graph

@@              Coverage Diff               @@
##           iroha2-dev    #1574      +/-   ##
==============================================
- Coverage       74.16%   73.98%   -0.19%     
==============================================
  Files             118      119       +1     
  Lines           19440    19651     +211     
==============================================
+ Hits            14418    14538     +120     
- Misses           5022     5113      +91     
Impacted Files Coverage Δ
telemetry/src/lib.rs 100.00% <ø> (ø)
telemetry/src/retry_period.rs 78.94% <78.94%> (ø)
telemetry/src/ws.rs 89.44% <90.90%> (+0.77%) ⬆️
telemetry/src/config.rs 100.00% <100.00%> (ø)
core/src/sumeragi/mod.rs 71.11% <0.00%> (-6.32%) ⬇️
actor/src/actor_id.rs 90.00% <0.00%> (-5.00%) ⬇️
core/src/sumeragi/view_change.rs 91.94% <0.00%> (-3.39%) ⬇️
p2p/tests/p2p.rs 98.29% <0.00%> (-1.29%) ⬇️
crypto/src/signature.rs 75.53% <0.00%> (-1.07%) ⬇️
core/src/sumeragi/network_topology.rs 89.74% <0.00%> (-0.77%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd84c85...b817543. Read the comment docs.

telemetry/src/config.rs Outdated Show resolved Hide resolved
telemetry/src/config.rs Show resolved Hide resolved
docs/source/references/config.md Outdated Show resolved Hide resolved
telemetry/src/ws.rs Outdated Show resolved Hide resolved
telemetry/src/ws.rs Outdated Show resolved Hide resolved
@s8sato s8sato linked an issue Nov 4, 2021 that may be closed by this pull request
telemetry/src/config.rs Show resolved Hide resolved
telemetry/src/ws.rs Outdated Show resolved Hide resolved
telemetry/src/ws.rs Outdated Show resolved Hide resolved
appetrosyan
appetrosyan previously approved these changes Nov 9, 2021
appetrosyan
appetrosyan previously approved these changes Nov 9, 2021
telemetry/src/types.rs Outdated Show resolved Hide resolved
telemetry/src/types.rs Outdated Show resolved Hide resolved
telemetry/src/ws.rs Outdated Show resolved Hide resolved
telemetry/src/ws.rs Outdated Show resolved Hide resolved
e-ivkov
e-ivkov previously approved these changes Nov 10, 2021
Signed-off-by: Alexey Kalita <kalita.alexey@outlook.com>
@KalitaAlexey KalitaAlexey merged commit a45326b into hyperledger:iroha2-dev Nov 10, 2021
@KalitaAlexey KalitaAlexey deleted the reconnect-telemetry branch November 10, 2021 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Enhancement New feature or request iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reconnect to telemetry
4 participants