[Feat] Add the number of connected peers to `Status` #1576

s8sato · 2021-11-03T16:47:53Z

Description of the Change

Number of connected peers, except for the reporting peer itself

Issue

Closes #1387

Benefits

Possible Drawbacks

codecov · 2021-11-03T16:59:21Z

Codecov Report

Merging #1576 (5e2403b) into iroha2-dev (abdc590) will decrease coverage by 3.89%.
The diff coverage is 72.96%.

@@              Coverage Diff               @@
##           iroha2-dev    #1576      +/-   ##
==============================================
- Coverage       77.07%   73.18%   -3.90%     
==============================================
  Files             122      123       +1     
  Lines           20141    21621    +1480     
==============================================
+ Hits            15524    15823     +299     
- Misses           4617     5798    +1181

Impacted Files	Coverage Δ
client/tests/tests/multiple_blocks_created.rs	`0.00% <0.00%> (ø)`
client_cli/src/main.rs	`0.27% <0.00%> (-0.14%)`	⬇️
core/src/smartcontracts/isi/mod.rs	`74.47% <ø> (-7.24%)`	⬇️
data_model/src/lib.rs	`59.28% <ø> (-7.15%)`	⬇️
p2p/src/lib.rs	`47.82% <ø> (+13.04%)`	⬆️
core/test_network/src/lib.rs	`65.57% <70.58%> (-14.84%)`	⬇️
p2p/src/network.rs	`65.48% <82.50%> (-13.47%)`	⬇️
p2p/tests/p2p.rs	`82.86% <82.60%> (-14.96%)`	⬇️
core/src/torii/mod.rs	`70.82% <84.84%> (-17.84%)`	⬇️
core/src/sumeragi/mod.rs	`72.04% <87.50%> (-17.43%)`	⬇️
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abdc590...5e2403b. Read the comment docs.

core/src/torii/mod.rs

e-ivkov · 2021-11-09T16:19:08Z

Also as suggested by Sofaine let's rename the endpoint to status.

client_cli/src/main.rs

core/src/sumeragi/mod.rs

core/src/torii/mod.rs

data_model/src/lib.rs

docs/source/references/api_spec.md

p2p/src/network.rs

e-ivkov · 2021-11-29T16:51:23Z

What do you think about splitting this PR into 2 separate PRs:

Introduce a status endpoint only with number of committed blocks.
Add number of connected peers feature and corrections to p2p that you want to introduce.

I think we will be able to merge the 1st one with minor corrections almost instantly. Then you will have time to work on the second one in detail.

This reverts commit b228b41. Signed-off-by: s8sato <49983831+s8sato@users.noreply.github.com>

Signed-off-by: s8sato <49983831+s8sato@users.noreply.github.com>

After your peer unregisters and disconnects another peer, your network will hear reconnection requests from the peer. All you can know at first is the address whose port number is arbitrary. So remember the unregistered peer by the part other than the port number and refuse reconnection from there Signed-off-by: s8sato <49983831+s8sato@users.noreply.github.com>

Signed-off-by: s8sato <49983831+s8sato@users.noreply.github.com>

github-actions bot added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Nov 3, 2021

s8sato force-pushed the feat/1387 branch 2 times, most recently from 57260c9 to 0c43641 Compare November 8, 2021 12:13

s8sato marked this pull request as ready for review November 8, 2021 12:16

s8sato requested review from appetrosyan, e-ivkov, GaroRobe, i1i1 and KalitaAlexey as code owners November 8, 2021 12:16

s8sato added api-changes Changes in the API for client libraries metrics labels Nov 8, 2021

s8sato force-pushed the feat/1387 branch from 0c43641 to 16e8f4f Compare November 8, 2021 13:08

s8sato linked an issue Nov 8, 2021 that may be closed by this pull request

Endpoint for smoke testing network status #1387

Closed

s8sato force-pushed the feat/1387 branch from 16e8f4f to 2e9677b Compare November 9, 2021 06:04

s8sato requested a review from mversic as a code owner November 9, 2021 06:04

appetrosyan self-assigned this Nov 9, 2021

appetrosyan reviewed Nov 9, 2021

View reviewed changes

core/src/torii/mod.rs Outdated Show resolved Hide resolved

s8sato force-pushed the feat/1387 branch from 2e9677b to f6989ca Compare November 9, 2021 06:59

s8sato mentioned this pull request Nov 9, 2021

Add prometheus endpoint #1216

Closed

s8sato marked this pull request as draft November 9, 2021 14:02

e-ivkov reviewed Nov 9, 2021

View reviewed changes

core/src/torii/mod.rs Outdated Show resolved Hide resolved

e-ivkov suggested changes Nov 9, 2021

View reviewed changes

core/src/torii/mod.rs Outdated Show resolved Hide resolved

appetrosyan changed the title ~~Add endpoint for internal metrics for administration~~ [Feat] Add endpoint for internal metrics for administration Nov 11, 2021

e-ivkov mentioned this pull request Nov 15, 2021

Add status endpoint support hyperledger/iroha-python#91

Open

s8sato force-pushed the feat/1387 branch from f6989ca to b92a28e Compare November 15, 2021 16:30

s8sato changed the title ~~[Feat] Add endpoint for internal metrics for administration~~ Add /status endpoint on specific port Nov 15, 2021

s8sato force-pushed the feat/1387 branch 2 times, most recently from 77c8461 to 5a9b748 Compare November 17, 2021 08:25

s8sato marked this pull request as draft November 29, 2021 03:49

appetrosyan reviewed Nov 29, 2021

View reviewed changes

appetrosyan changed the title ~~Add /status endpoint to a specific port~~ [Feat] Add /status endpoint to a specific port Nov 29, 2021

appetrosyan changed the title ~~[Feat] Add /status endpoint to a specific port~~ [Feat] Add /status endpoint to a specific port Nov 29, 2021

s8sato marked this pull request as ready for review November 29, 2021 08:56

s8sato changed the title ~~[Feat] Add /status endpoint to a specific port~~ Add the number of connected peers to Status Nov 30, 2021

s8sato marked this pull request as draft November 30, 2021 07:04

s8sato mentioned this pull request Nov 30, 2021

[Feat] Add /status endpoint to a specific port #1646

Merged

s8sato force-pushed the feat/1387 branch from d619f47 to 8a3eee6 Compare November 30, 2021 10:37

s8sato marked this pull request as ready for review November 30, 2021 10:38

s8sato force-pushed the feat/1387 branch 2 times, most recently from 816098c to 0bd819a Compare November 30, 2021 12:24

appetrosyan previously approved these changes Nov 30, 2021

View reviewed changes

s8sato added 9 commits November 30, 2021 21:39

Revert "Delete things related to the number of connected peers"

2291e11

This reverts commit b228b41. Signed-off-by: s8sato <49983831+s8sato@users.noreply.github.com>

Clarify Peer has true public key only after handshake

cb263c0

Signed-off-by: s8sato <49983831+s8sato@users.noreply.github.com>

DisconnectPeer without tests

6452e9d

Signed-off-by: s8sato <49983831+s8sato@users.noreply.github.com>

Implement unregister peer execution

463020d

Signed-off-by: s8sato <49983831+s8sato@users.noreply.github.com>

Add (un)register peer subcommand to client_cli

932c846

Signed-off-by: s8sato <49983831+s8sato@users.noreply.github.com>

Remove client_cli maintenance subcommand guide

f080421

Signed-off-by: s8sato <49983831+s8sato@users.noreply.github.com>

Apply review comments up to #discussion_r758027645

edff470

Signed-off-by: s8sato <49983831+s8sato@users.noreply.github.com>

Give status_url configuration for TestClient

5e2403b

Signed-off-by: s8sato <49983831+s8sato@users.noreply.github.com>

s8sato dismissed appetrosyan’s stale review via 5e2403b November 30, 2021 12:40

s8sato force-pushed the feat/1387 branch from 0bd819a to 5e2403b Compare November 30, 2021 12:40

appetrosyan approved these changes Nov 30, 2021

View reviewed changes

s8sato changed the title ~~Add the number of connected peers to Status~~ [Feat] Add the number of connected peers to Status Nov 30, 2021

e-ivkov approved these changes Nov 30, 2021

View reviewed changes

appetrosyan merged commit 60cbd05 into hyperledger:iroha2-dev Nov 30, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Feat] Add the number of connected peers to `Status` #1576

[Feat] Add the number of connected peers to `Status` #1576

s8sato commented Nov 3, 2021 •

edited

Loading

codecov bot commented Nov 3, 2021 •

edited

Loading

e-ivkov commented Nov 9, 2021

e-ivkov commented Nov 29, 2021 •

edited

Loading

[Feat] Add the number of connected peers to Status #1576

[Feat] Add the number of connected peers to Status #1576

Conversation

s8sato commented Nov 3, 2021 • edited Loading

Description of the Change

Issue

Benefits

Possible Drawbacks

codecov bot commented Nov 3, 2021 • edited Loading

Codecov Report

e-ivkov commented Nov 9, 2021

e-ivkov commented Nov 29, 2021 • edited Loading

[Feat] Add the number of connected peers to `Status` #1576

[Feat] Add the number of connected peers to `Status` #1576

s8sato commented Nov 3, 2021 •

edited

Loading

codecov bot commented Nov 3, 2021 •

edited

Loading

e-ivkov commented Nov 29, 2021 •

edited

Loading