Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove proposal_delay timeout (#1831) #1847

Merged
merged 2 commits into from
Mar 22, 2022
Merged

Remove proposal_delay timeout (#1831) #1847

merged 2 commits into from
Mar 22, 2022

Conversation

paul-cpp
Copy link

Description of the Change

  • Remove proposal_delay timeout
  • proposal_delay = proposal_creation_timeout * 2

Issue

Remove proposal_delay timeout #1831

Benefits

Possible Drawbacks

Usage Examples or Tests [optional]

Alternate Designs [optional]

@paul-cpp paul-cpp requested a review from iceseer January 26, 2022 19:30
@psachkov
Remove proposal_delay timeout (#1831)
83f2dd7 
Signed-off-by: Pavel Sachkov <paul.pix71@gmail.com>
@iceseer
Copy link
Contributor

iceseer commented Feb 2, 2022

Looks good. Thank you. Will approve it after 1.4 testing complete.

@iceseer iceseer added 1.4.1 and removed 1.x labels Feb 10, 2022
@iceseer
Copy link
Contributor

iceseer commented Mar 3, 2022

It will be better to make IrohaSettings abstraction. It means we can make 2 functions: getProposalDelay and getProposalCreationTimeout to hide the calculation from other code. Instead of now we need to to know and insert multiplication on 2 each time we use getProposalDelay.

@iceseer iceseer merged commit 7cd04f7 into develop Mar 22, 2022
@iceseer iceseer deleted the develop-fix-1831 branch March 22, 2022 13:26
iceseer added a commit that referenced this pull request Apr 8, 2022
@psachkov @iceseer
Remove proposal_delay timeout (#1831) (#1847)
cd9e970 
Signed-off-by: Pavel Sachkov <paul.pix71@gmail.com>
Signed-off-by: Paul Sachkov <paul.pix71@gmail.com>

Co-authored-by: Alexander Lednev <57529355+iceseer@users.noreply.github.com>
@nxsaken nxsaken added the iroha1 The legacy version of Iroha. label Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iceseer iceseer iceseer approved these changes

Assignees

@iceseer iceseer

Labels
1.4.1 iroha1 The legacy version of Iroha.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@paul-cpp @iceseer @appetrosyan @nxsaken @psachkov