Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] #1640: Generate genesis.json and consolidate generation into one tool #2104

Merged
merged 5 commits into from Apr 27, 2022
Merged

[fix] #1640: Generate genesis.json and consolidate generation into one tool #2104

merged 5 commits into from Apr 27, 2022

Conversation

appetrosyan
Copy link
Contributor

@appetrosyan appetrosyan commented Apr 14, 2022 •
edited

Description of the Change

Can now use iroha_docs binary to generate sample genesis.json

Issue

Closes #1640
Closes #1992
Fixes #2081

Benefits

Can now generate and check if the genesis.json needs updating.

Possible Drawbacks

None

Usage Examples or Tests [optional]

cargo run --bin iroha_docs -- --genesis > /tmp/genesis.json && diff /tmp/genesis.json  configs/peer/genesis.json

@github-actions github-actions bot added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Apr 14, 2022
@appetrosyan appetrosyan marked this pull request as draft April 14, 2022 13:28
@appetrosyan appetrosyan force-pushed the i2-roles-fix branch 2 times, most recently from 245ad4a to 33d75bc Compare April 14, 2022 19:01
@appetrosyan appetrosyan changed the title [fix] #1640: Generate config.json and genesis.json [fix] #1640: Generate genesis.json and consolidate generation into one tool Apr 14, 2022
@appetrosyan appetrosyan added CI Refactor Improvement to overall code quality labels Apr 14, 2022
@appetrosyan appetrosyan marked this pull request as ready for review April 15, 2022 07:42
@appetrosyan appetrosyan mentioned this pull request Apr 15, 2022
Closed
@appetrosyan appetrosyan force-pushed the i2-roles-fix branch 3 times, most recently from 0cca2ba to faa3219 Compare April 15, 2022 11:49
mversic
mversic requested changes Apr 15, 2022
View reviewed changes
data_model/src/domain.rs Outdated Show resolved Hide resolved
data_model/src/domain.rs Outdated Show resolved Hide resolved
tools/generator/src/main.rs Outdated Show resolved Hide resolved
core/src/genesis.rs Outdated Show resolved Hide resolved
core/src/genesis.rs Outdated Show resolved Hide resolved
@appetrosyan appetrosyan force-pushed the i2-roles-fix branch 2 times, most recently from 6509b80 to 10362e5 Compare April 15, 2022 15:30
@appetrosyan appetrosyan mentioned this pull request Apr 15, 2022
Merged
@appetrosyan appetrosyan force-pushed the i2-roles-fix branch 2 times, most recently from c5404d6 to ad9090b Compare April 16, 2022 06:40
mversic
mversic previously approved these changes Apr 16, 2022
View reviewed changes
core/src/genesis.rs Show resolved Hide resolved
crypto/src/signature.rs Outdated Show resolved Hide resolved
@appetrosyan appetrosyan force-pushed the i2-roles-fix branch 3 times, most recently from b732543 to 3e69547 Compare April 18, 2022 12:19
@mversic mversic self-requested a review April 18, 2022 13:29
@appetrosyan
[fix] hyperledger#1640: Generate config.json and genesis.json
b52cd77 
Signed-off-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru>
@appetrosyan
[refactor]: Create iroha_gen binary, consolidating docs, schema_bin
32509e5 
Signed-off-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru>
@appetrosyan
[ci]: Add genesis check and update documentation.
f6a9865 
Signed-off-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru>
@appetrosyan
[fix] hyperledger#2081: Fix role registration.
3bf0dd7 
Signed-off-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru>
@appetrosyan appetrosyan force-pushed the i2-roles-fix branch 6 times, most recently from f79a8a8 to d775519 Compare April 26, 2022 07:09
@appetrosyan appetrosyan mentioned this pull request Apr 26, 2022
Closed
SamHSmith
SamHSmith previously approved these changes Apr 26, 2022
View reviewed changes
Copy link
Contributor

@SamHSmith SamHSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright. Can't see anything I think should be different.

s8sato
s8sato reviewed Apr 26, 2022
View reviewed changes
.github/workflows/iroha2-dev-pr.yml Show resolved Hide resolved
.github/workflows/iroha2.yml Show resolved Hide resolved
client/build.rs Show resolved Hide resolved
client/tests/integration/roles.rs Show resolved Hide resolved
client_cli/src/main.rs Show resolved Hide resolved
tools/kagami/Cargo.toml Outdated Show resolved Hide resolved
@appetrosyan appetrosyan force-pushed the i2-roles-fix branch 2 times, most recently from 63b639c to 1dd9cbf Compare April 26, 2022 12:25
SamHSmith
SamHSmith previously approved these changes Apr 26, 2022
View reviewed changes
@appetrosyan
[refactor]: Move to clap.
c2c25df 
Signed-off-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru>
@appetrosyan appetrosyan enabled auto-merge (rebase) April 27, 2022 07:00
@appetrosyan appetrosyan merged commit 0652de5 into hyperledger:iroha2-dev Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamHSmith SamHSmith SamHSmith approved these changes

@s8sato s8sato s8sato approved these changes

@QuentinI QuentinI Awaiting requested review from QuentinI

@mversic mversic Awaiting requested review from mversic

@Arjentix Arjentix Awaiting requested review from Arjentix

Assignees
No one assigned
Labels
CI iroha2-dev The re-implementation of a BFT hyperledger in RUST Refactor Improvement to overall code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@appetrosyan @Arjentix @SamHSmith @mversic @s8sato