[schema] #2108: Add pagination #2107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
iroha2-dev
appetrosyan
force-pushed
the
i2-pagination
branch
from
2e1058d
to
f53b086
Compare
Arjentix
previously approved these changes
Apr 15, 2022
appetrosyan
changed the title
appetrosyan
changed the title
mversic
reviewed
Apr 15, 2022
appetrosyan
force-pushed
the
i2-pagination
branch
2 times, most recently
from
95f6577
to
b8438b1
Compare
appetrosyan
force-pushed
the
i2-pagination
branch
from
b8438b1
to
332c936
Compare
appetrosyan
force-pushed
the
i2-pagination
branch
from
332c936
to
7a68b29
Compare
appetrosyan
force-pushed
the
i2-pagination
branch
from
7a68b29
to
eb19963
Compare
s8sato
reviewed
Apr 20, 2022
Comment on lines
-112
to
+114
| ) -> Result<Scale<VersionedQueryResult>, warp::http::Response<warp::hyper::Body>> { | ||
| ) -> Result<Scale<VersionedPaginatedQueryResult>, warp::http::Response<warp::hyper::Body>> { |
There was a problem hiding this comment.
The strange thing is that Client still expects a VersionedQueryResult in request_with_pagination, but seems to successfully decode a query result that is actually a VersionedPaginatedQueryResult
There was a problem hiding this comment.
BTW maybe this PR should be categorized as [schema]?
There was a problem hiding this comment.
Not PR, but commit. If you try to add schema to the PR title, it will not pass CI.
There was a problem hiding this comment.
The strange thing is that Client still expects a VersionedQueryResult in request_with_pagination, but seems to successfully decode a query result that is actually a VersionedPaginatedQueryResult
I'm guessing that it tries to decode the subset that is a VersionedQueryResult, but it should be updated. Good catch.
There was a problem hiding this comment.
Not PR, but commit. If you try to add
schemato the PR title, it will not pass CI.
Timely, #2115 shows an exception
There was a problem hiding this comment.
Ok, later I can resolve the appearance discrepancy between VersionedPaginatedQueryResult and VersionedQueryResult
appetrosyan
force-pushed
the
i2-pagination
branch
from
eb19963
to
cf31d89
Compare
Signed-off-by: BAStos525 <66615487+BAStos525@users.noreply.github.com>
Signed-off-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru>
appetrosyan
force-pushed
the
i2-pagination
branch
from
cf31d89
to
1a1a835
Compare
appetrosyan
changed the title
mversic
previously approved these changes
Apr 20, 2022
Signed-off-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru>
appetrosyan
force-pushed
the
i2-pagination
branch
from
1a1a835
to
fa7dd77
Compare
mversic
approved these changes
Apr 20, 2022
s8sato
approved these changes
Apr 20, 2022
appetrosyan
changed the title
mversic
pushed a commit
to mversic/iroha
that referenced
this pull request
May 2, 2022
appetrosyan
added a commit
to appetrosyan/iroha
that referenced
this pull request
May 4, 2022
Signed-off-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru>
appetrosyan
added a commit
to appetrosyan/iroha
that referenced
this pull request
May 12, 2022
appetrosyan
added a commit
to appetrosyan/iroha
that referenced
this pull request
May 12, 2022
appetrosyan
added a commit
to appetrosyan/iroha
that referenced
this pull request
May 12, 2022
Signed-off-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru>
appetrosyan
added a commit
to appetrosyan/iroha
that referenced
this pull request
May 12, 2022
Signed-off-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru>
appetrosyan
added a commit
to appetrosyan/iroha
that referenced
this pull request
May 12, 2022
Signed-off-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru>
appetrosyan
added a commit
to appetrosyan/iroha
that referenced
this pull request
May 12, 2022
Signed-off-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru>
mversic
pushed a commit
to mversic/iroha
that referenced
this pull request
May 13, 2022
mversic
pushed a commit
to mversic/iroha
that referenced
this pull request
May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: BAStos525 66615487+BAStos525@users.noreply.github.com
Description of the Change
Add pagination support for SDKs.
Issue
Closes #2108
Benefits
Pagination added to queries, so that SDKs have access to the Pagination struct.