[feature] #2121: Check keypair is valid when constructed #2130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mversic
commented
Apr 21, 2022
mversic
force-pushed
the
keypair_check
branch
5 times, most recently
from
29d6c76
to
8db62aa
Compare
appetrosyan
force-pushed
the
keypair_check
branch
from
8db62aa
to
e77b098
Compare
Arjentix
reviewed
Apr 21, 2022
mversic
force-pushed
the
keypair_check
branch
2 times, most recently
from
eb3bd2f
to
2ef7663
Compare
mversic
force-pushed
the
keypair_check
branch
2 times, most recently
from
4fb25e2
to
960d8c7
Compare
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
s8sato
approved these changes
Apr 24, 2022
appetrosyan
approved these changes
Apr 25, 2022
mversic
added a commit
to mversic/iroha
that referenced
this pull request
May 2, 2022
…yperledger#2130) Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
appetrosyan
pushed a commit
to appetrosyan/iroha
that referenced
this pull request
May 4, 2022
appetrosyan
pushed a commit
to appetrosyan/iroha
that referenced
this pull request
May 12, 2022
appetrosyan
pushed a commit
to appetrosyan/iroha
that referenced
this pull request
May 12, 2022
appetrosyan
pushed a commit
to appetrosyan/iroha
that referenced
this pull request
May 12, 2022
appetrosyan
pushed a commit
to appetrosyan/iroha
that referenced
this pull request
May 12, 2022
appetrosyan
pushed a commit
to appetrosyan/iroha
that referenced
this pull request
May 12, 2022
appetrosyan
pushed a commit
to appetrosyan/iroha
that referenced
this pull request
May 12, 2022
appetrosyan
pushed a commit
to appetrosyan/iroha
that referenced
this pull request
May 12, 2022
…yperledger#2130) Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
mversic
added a commit
to mversic/iroha
that referenced
this pull request
May 13, 2022
…yperledger#2130) Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
mversic
added a commit
to mversic/iroha
that referenced
this pull request
May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Marin Veršić marin.versic101@gmail.com
Description of the Change
I thought it might be useful to fail fast on invalid configuration. Should save us some debugging time. The gist of the change is in the
KeyPair::newmethodCloses #2121
Issue
Benefits
Possible Drawbacks
Usage Examples or Tests [optional]
Alternate Designs [optional]