Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve parity_scale_decoder tests #2159

Closed
appetrosyan opened this issue Apr 28, 2022 · 0 comments
Closed

Improve parity_scale_decoder tests #2159

appetrosyan opened this issue Apr 28, 2022 · 0 comments
Assignees
@Arjentix
Labels
Bug Something isn't working iroha2-dev The re-implementation of a BFT hyperledger in RUST Tests

Comments

@appetrosyan
Copy link
Contributor

Currently the decoding test is white-space sensitive. It's incredibly difficult to figure out what's wrong given two blocks of text with tonnes of whitespace and escape characters.

Given that we have serde_json we should avoid string-based comparisons, and instead rely more on the serde-based output.
@appetrosyan appetrosyan added Bug Something isn't working iroha2-dev The re-implementation of a BFT hyperledger in RUST Tests labels Apr 28, 2022
@Arjentix Arjentix mentioned this issue May 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Arjentix Arjentix

Labels
Bug Something isn't working iroha2-dev The re-implementation of a BFT hyperledger in RUST Tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@appetrosyan @Arjentix