[feature] #2161: Handle id and shared FFI fns #2274

mversic · 2022-05-26T22:15:23Z

Description of the Change

I've extracted some of the work which comprises a full feature:

implement Handle for every opaque pointer handle
generate implementations of shared FFI functions

Issue

Relates to #2161

Benefits

Possible Drawbacks

Usage Examples or Tests [optional]

Alternate Designs [optional]

ffi/src/lib.rs

codecov · 2022-05-26T23:11:52Z

Codecov Report

Merging #2274 (2f630c3) into iroha2-dev (5ddb17c) will increase coverage by 0.81%.
The diff coverage is 67.17%.

@@              Coverage Diff               @@
##           iroha2-dev    #2274      +/-   ##
==============================================
+ Coverage       64.67%   65.49%   +0.81%     
==============================================
  Files             131      133       +2     
  Lines           24666    24693      +27     
==============================================
+ Hits            15953    16172     +219     
+ Misses           8713     8521     -192

Impacted Files	Coverage Δ
config/src/lib.rs	`14.28% <0.00%> (ø)`
core/src/smartcontracts/isi/account.rs	`12.30% <0.00%> (ø)`
core/src/smartcontracts/isi/domain.rs	`39.82% <0.00%> (+0.69%)`	⬆️
core/src/smartcontracts/isi/triggers.rs	`0.00% <ø> (ø)`
core/src/smartcontracts/isi/world.rs	`9.09% <0.00%> (ø)`
data_model/src/asset.rs	`51.46% <0.00%> (-0.42%)`	⬇️
data_model/src/block_value.rs	`57.14% <ø> (+17.14%)`	⬆️
data_model/src/domain.rs	`77.77% <0.00%> (ø)`
data_model/src/trigger/set.rs	`33.21% <0.00%> (ø)`
ffi/src/lib.rs	`2.98% <0.00%> (-63.69%)`	⬇️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3671e02...2f630c3. Read the comment docs.

data_model/src/expression.rs

data_model/src/lib.rs

ffi/src/lib.rs

ffi/tests/gen_shared_fns.rs

…Eq,Ord Signed-off-by: Marin Veršić <marin.versic101@gmail.com>

Signed-off-by: Marin Veršić <marin.versic101@gmail.com>

data_model/src/lib.rs

ffi/src/lib.rs

ffi/derive/src/bindgen.rs

Signed-off-by: Marin Veršić <marin.versic101@gmail.com>

…#2274) * add handle id and implement FFI equivalents of shared traits - Clone,Eq,Ord Signed-off-by: Marin Veršić <marin.versic101@gmail.com> * add tests for generated shared ffi functions Signed-off-by: Marin Veršić <marin.versic101@gmail.com> * move Handle trait definition from ffi into crate deriving handles! Signed-off-by: Marin Veršić <marin.versic101@gmail.com> * remove Ord noise Signed-off-by: Marin Veršić <marin.versic101@gmail.com> Signed-off-by: BAStos525 <jungle.vas@yandex.ru>

mversic changed the title ~~[feature]: #0000 Handle id and shared FFI fns~~ [feature] #0000: Handle id and shared FFI fns May 26, 2022

mversic changed the base branch from main to iroha2-dev May 26, 2022 22:15

mversic force-pushed the handle_id_common_fns branch from a289b09 to e3ae6d9 Compare May 26, 2022 22:16

mversic changed the title ~~[feature] #0000: Handle id and shared FFI fns~~ [feature] #2161: Handle id and shared FFI fns May 26, 2022

mversic commented May 26, 2022

View reviewed changes

ffi/src/lib.rs Outdated Show resolved Hide resolved

mversic marked this pull request as ready for review May 26, 2022 22:30

mversic requested review from s8sato, appetrosyan, Arjentix, SamHSmith, QuentinI and outoftardis as code owners May 26, 2022 22:30

mversic force-pushed the handle_id_common_fns branch from 013cea1 to 827c10e Compare May 26, 2022 22:54

mversic force-pushed the handle_id_common_fns branch 2 times, most recently from 6ed472f to 6e2db8f Compare May 27, 2022 08:03

appetrosyan added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label May 27, 2022

appetrosyan reviewed May 27, 2022

View reviewed changes

data_model/src/expression.rs Show resolved Hide resolved

data_model/src/lib.rs Show resolved Hide resolved

mversic force-pushed the handle_id_common_fns branch from 6e2db8f to 258d451 Compare May 27, 2022 21:00

appetrosyan previously approved these changes May 31, 2022

View reviewed changes

appetrosyan self-assigned this May 31, 2022

mversic dismissed appetrosyan’s stale review via 6e508d1 May 31, 2022 07:26

mversic force-pushed the handle_id_common_fns branch from 258d451 to 6e508d1 Compare May 31, 2022 07:26

mversic requested a review from appetrosyan May 31, 2022 07:26

outoftardis reviewed May 31, 2022

View reviewed changes

ffi/src/lib.rs Outdated Show resolved Hide resolved

ffi/tests/gen_shared_fns.rs Show resolved Hide resolved

mversic force-pushed the handle_id_common_fns branch from 6e508d1 to 0fd303a Compare May 31, 2022 08:23

mversic requested a review from outoftardis May 31, 2022 08:28

s8sato self-assigned this May 31, 2022

mversic force-pushed the handle_id_common_fns branch from 0fd303a to a8fe7af Compare May 31, 2022 13:53

appetrosyan previously approved these changes Jun 1, 2022

View reviewed changes

mversic dismissed appetrosyan’s stale review via 344b192 June 1, 2022 07:24

mversic force-pushed the handle_id_common_fns branch 2 times, most recently from 344b192 to d8daf7d Compare June 1, 2022 07:35

mversic requested a review from ilchu as a code owner June 1, 2022 07:35

mversic requested a review from appetrosyan June 1, 2022 07:42

appetrosyan previously approved these changes Jun 1, 2022

View reviewed changes

mversic dismissed appetrosyan’s stale review via 1bd4867 June 1, 2022 07:47

mversic force-pushed the handle_id_common_fns branch from d8daf7d to 1bd4867 Compare June 1, 2022 07:47

mversic requested a review from appetrosyan June 1, 2022 07:48

mversic added 3 commits June 1, 2022 10:17

add handle id and implement FFI equivalents of shared traits - Clone,…

d0c7f12

…Eq,Ord Signed-off-by: Marin Veršić <marin.versic101@gmail.com>

add tests for generated shared ffi functions

1d35f53

Signed-off-by: Marin Veršić <marin.versic101@gmail.com>

move Handle trait definition from ffi into crate deriving handles!

4fc639d

Signed-off-by: Marin Veršić <marin.versic101@gmail.com>

mversic force-pushed the handle_id_common_fns branch from 1bd4867 to 5674745 Compare June 1, 2022 08:17

s8sato reviewed Jun 1, 2022

View reviewed changes

data_model/src/lib.rs Show resolved Hide resolved

ffi/src/lib.rs Show resolved Hide resolved

ffi/derive/src/bindgen.rs Show resolved Hide resolved

remove Ord noise

2f630c3

Signed-off-by: Marin Veršić <marin.versic101@gmail.com>

mversic force-pushed the handle_id_common_fns branch from 5674745 to 2f630c3 Compare June 1, 2022 14:11

mversic requested a review from s8sato June 1, 2022 14:11

s8sato approved these changes Jun 1, 2022

View reviewed changes

appetrosyan approved these changes Jun 1, 2022

View reviewed changes

mversic merged commit efa9a35 into hyperledger:iroha2-dev Jun 1, 2022

mversic deleted the handle_id_common_fns branch December 27, 2022 23:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[feature] #2161: Handle id and shared FFI fns #2274

[feature] #2161: Handle id and shared FFI fns #2274

mversic commented May 26, 2022 •

edited

codecov bot commented May 26, 2022 •

edited

[feature] #2161: Handle id and shared FFI fns #2274

[feature] #2161: Handle id and shared FFI fns #2274

Conversation

mversic commented May 26, 2022 • edited

Description of the Change

Issue

Benefits

Possible Drawbacks

Usage Examples or Tests [optional]

Alternate Designs [optional]

codecov bot commented May 26, 2022 • edited

Codecov Report

mversic commented May 26, 2022 •

edited

codecov bot commented May 26, 2022 •

edited