[refactor] #2238: Add peer builder for tests #2304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## iroha2-dev #2304 +/- ##
==============================================
- Coverage 65.50% 65.38% -0.12%
==============================================
Files 133 133
Lines 24697 24801 +104
==============================================
+ Hits 16177 16216 +39
- Misses 8520 8585 +65
Continue to review full report at Codecov.
|
|
@Arjentix seems you know the context so can you please review it? Would be great if you leave some feedback on the |
Arjentix
reviewed
Jun 2, 2022
| @@ -16,22 +16,22 @@ use super::Configuration; | |||
| fn restarted_peer_should_have_the_same_asset_amount() -> Result<()> { | |||
| let temp_dir = Arc::new(TempDir::new()?); | |||
|
|
|||
| let mut configuration = Configuration::test(); | |||
| let mut peer = <TestPeer>::new()?; | |||
| configuration.sumeragi.trusted_peers.peers = std::iter::once(peer.id.clone()).collect(); | |||
client/benches/torii.rs
Outdated
Comment on lines
38
to
39
| .expect("genesis creation failed") | ||
| .expect("genesis created"); |
There was a problem hiding this comment.
That's strange... Looks like it should be two different expectations but the message is pretty the same...
pesterev
force-pushed
the
peer-builder
branch
3 times, most recently
from
acc0305
to
94f5732
Compare
outoftardis
reviewed
Jun 6, 2022
pesterev
force-pushed
the
peer-builder
branch
2 times, most recently
from
cca42bc
to
24ad0a4
Compare
pesterev
requested review from
s8sato,
appetrosyan,
mversic,
SamHSmith,
QuentinI and
ilchu
as code owners
outoftardis
reviewed
Jun 6, 2022
Arjentix
reviewed
Jun 6, 2022
Signed-off-by: Vladimir Pesterev <pesterev@pm.me>
outoftardis
approved these changes
Jun 6, 2022
Arjentix
approved these changes
Jun 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This replaces nested methods which creates
PeerwithPeerBuilderstructure (Builder pattern).Issue
Resolves #2238
Benefits
Makes creating a test environment more flexible and convenient.
Possible Drawbacks
Idk may increase test run time.
Alternate Designs [optional]
Make
Peerstructure a builder itself. But in that design, will need to keep parameters (genesis,configuration,instruction_validator,query_validator,temp_dir) inside thePeerstructure to start the peer's task - it will makesPeerstructure a huge.