Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] #2081: Fix the test case to grant the role #2312

Merged
merged 1 commit into from
Jun 4, 2022

Conversation

s8sato
Copy link
Contributor

@s8sato s8sato commented Jun 3, 2022

Description of the Change

Issue

Benefits

  • Prevent regressions in the future
  • Show a minimum example of how to grant roles

Possible Drawbacks

None

@github-actions github-actions bot added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Jun 3, 2022
@codecov
Copy link

codecov bot commented Jun 3, 2022

Codecov Report

Merging #2312 (11b2bc4) into iroha2-dev (6973f71) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

@@              Coverage Diff               @@
##           iroha2-dev    #2312      +/-   ##
==============================================
- Coverage       65.50%   65.43%   -0.07%     
==============================================
  Files             133      133              
  Lines           24697    24720      +23     
==============================================
- Hits            16177    16176       -1     
- Misses           8520     8544      +24     
Impacted Files Coverage Δ
client/src/client.rs 44.04% <0.00%> (-0.81%) ⬇️
core/src/smartcontracts/isi/mod.rs 52.45% <0.00%> (-0.14%) ⬇️
core/src/smartcontracts/isi/world.rs 9.52% <0.00%> (+0.43%) ⬆️
data_model/src/query.rs 39.34% <0.00%> (-1.90%) ⬇️
tools/kura_inspector/src/print.rs 96.15% <0.00%> (-0.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74fdadb...11b2bc4. Read the comment docs.

@s8sato s8sato changed the title [fix] #2081: Grant and find roles [test] #2081: Grant and find roles Jun 3, 2022
@s8sato s8sato marked this pull request as draft June 3, 2022 09:39
Signed-off-by: Shunkichi Sato <49983831+s8sato@users.noreply.github.com>
@s8sato s8sato marked this pull request as ready for review June 3, 2022 16:04
@s8sato s8sato changed the title [test] #2081: Grant and find roles [fix] #2081: Fix the test case to grant the role Jun 3, 2022
@s8sato s8sato enabled auto-merge (rebase) June 3, 2022 16:26
@s8sato s8sato merged commit 20e4238 into hyperledger:iroha2-dev Jun 4, 2022
@Arjentix
Copy link
Contributor

Arjentix commented Jun 4, 2022

Though I don't think it closes the issue, cause I think SDK-developers still getting their error and we need to help them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants