[feature] #2053: Add tests to the asset-related queries in private blockchain #2374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pesterev
requested review from
s8sato,
appetrosyan,
mversic,
Arjentix,
SamHSmith,
QuentinI,
outoftardis,
ilchu and
Erigara
as code owners
github-actions
bot
added
the
iroha2-dev
pesterev
force-pushed
the
private_blockchain_permissions_tests_2
branch
from
fbaad7b
to
0278882
Compare
Codecov Report
@@ Coverage Diff @@
## iroha2-dev #2374 +/- ##
==============================================
+ Coverage 65.50% 67.95% +2.45%
==============================================
Files 133 140 +7
Lines 24697 26635 +1938
==============================================
+ Hits 16177 18099 +1922
- Misses 8520 8536 +16
Continue to review full report at Codecov.
|
appetrosyan
reviewed
Jun 20, 2022
| } | ||
|
|
||
| #[test] | ||
| fn find_assets_by_domain_id() { |
There was a problem hiding this comment.
Is this supposed to be outside mod queries?
There was a problem hiding this comment.
If so, I'd add an explicit mod that explains what these tests are.
There was a problem hiding this comment.
Ah, that's after the wrong rebase. Thanks, fixed.
pesterev
force-pushed
the
private_blockchain_permissions_tests_2
branch
2 times, most recently
from
2794ef9
to
0867a4b
Compare
pesterev
force-pushed
the
private_blockchain_permissions_tests_2
branch
from
0867a4b
to
b7fc38c
Compare
appetrosyan
approved these changes
Jun 21, 2022
Erigara
reviewed
Jun 21, 2022
s8sato
approved these changes
Jun 21, 2022
… private blockchain Signed-off-by: Vladimir Pesterev <pesterev@pm.me>
appetrosyan
force-pushed
the
private_blockchain_permissions_tests_2
branch
from
b7fc38c
to
7c9dd7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Add tests to the asset-related queries in private blockchain.
Issue
Partially resolves #2053 .
Benefits
New tests.
Possible Drawbacks
None.