-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] #2360: Make genesis.json
optional again
#2390
Conversation
Codecov Report
@@ Coverage Diff @@
## iroha2-dev #2390 +/- ##
==============================================
+ Coverage 65.50% 70.06% +4.56%
==============================================
Files 133 142 +9
Lines 24697 27894 +3197
==============================================
+ Hits 16177 19545 +3368
+ Misses 8520 8349 -171
Continue to review full report at Codecov.
|
29d4499
to
173a0e3
Compare
145031f
to
2ee18eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this commit should be categorized as a [fix]
because it will change the functionality of the code to what it should be
genesis.json
optional againgenesis.json
optional again
Signed-off-by: Ilia Churin <churin.ilya@gmail.com>
e847ed0
to
f05cfd5
Compare
…ledger#2390) Signed-off-by: Ilia Churin <churin.ilya@gmail.com> Signed-off-by: BAStos525 <jungle.vas@yandex.ru>
Signed-off-by: Ilia Churin churin.ilya@gmail.com
Description of the Change
Pretty much wrapping
GenesisConfiguration
fromcli
crate into anOption
to allow peer startup without agenesis.json
if they're not submitting genesis.Issue
Resolves #2360 .
Benefits
More flexibility with deployment.
Possible Drawbacks
Slightly wordier initialization of all the related structs, as we have to wrap in
Some
.