Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] #2360: Make genesis.json optional again #2390

Merged
merged 1 commit into from
Jun 24, 2022

Conversation

ilchu
Copy link
Contributor

@ilchu ilchu commented Jun 23, 2022

Signed-off-by: Ilia Churin churin.ilya@gmail.com

Description of the Change

Pretty much wrapping GenesisConfiguration from cli crate into an Option to allow peer startup without a genesis.json if they're not submitting genesis.

Issue

Resolves #2360 .

Benefits

More flexibility with deployment.

Possible Drawbacks

Slightly wordier initialization of all the related structs, as we have to wrap in Some.

@github-actions github-actions bot added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Jun 23, 2022
@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #2390 (e847ed0) into iroha2-dev (6973f71) will increase coverage by 4.56%.
The diff coverage is 69.19%.

❗ Current head e847ed0 differs from pull request most recent head f05cfd5. Consider uploading reports for the commit f05cfd5 to get more accurate results

@@              Coverage Diff               @@
##           iroha2-dev    #2390      +/-   ##
==============================================
+ Coverage       65.50%   70.06%   +4.56%     
==============================================
  Files             133      142       +9     
  Lines           24697    27894    +3197     
==============================================
+ Hits            16177    19545    +3368     
+ Misses           8520     8349     -171     
Impacted Files Coverage Δ
cli/derive/src/lib.rs 74.72% <ø> (ø)
cli/src/main.rs 1.35% <0.00%> (-0.04%) ⬇️
cli/src/torii/mod.rs 28.88% <ø> (ø)
config/src/lib.rs 15.38% <0.00%> (+1.09%) ⬆️
core/src/lib.rs 100.00% <ø> (ø)
core/src/smartcontracts/isi/block.rs 100.00% <ø> (ø)
core/src/smartcontracts/isi/domain.rs 39.82% <ø> (ø)
core/src/smartcontracts/isi/triggers.rs 0.00% <0.00%> (ø)
core/src/smartcontracts/isi/tx.rs 25.00% <ø> (ø)
core/src/smartcontracts/isi/world.rs 9.52% <0.00%> (+0.43%) ⬆️
... and 107 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9d2d4c...f05cfd5. Read the comment docs.

@ilchu ilchu force-pushed the no_genesis_peers branch 4 times, most recently from 29d4499 to 173a0e3 Compare June 23, 2022 15:23
appetrosyan
appetrosyan previously approved these changes Jun 23, 2022
cli/src/main.rs Outdated Show resolved Hide resolved
@s8sato s8sato self-assigned this Jun 23, 2022
@ilchu ilchu force-pushed the no_genesis_peers branch 5 times, most recently from 145031f to 2ee18eb Compare June 24, 2022 07:00
appetrosyan
appetrosyan previously approved these changes Jun 24, 2022
Copy link
Contributor

@s8sato s8sato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this commit should be categorized as a [fix] because it will change the functionality of the code to what it should be

@appetrosyan appetrosyan changed the title [refactor] #2360: Make genesis.json optional again [feature] #2360: Make genesis.json optional again Jun 24, 2022
Signed-off-by: Ilia Churin <churin.ilya@gmail.com>
@appetrosyan appetrosyan merged commit 6a28d6a into hyperledger:iroha2-dev Jun 24, 2022
BAStos525 pushed a commit to BAStos525/soramitsu-iroha that referenced this pull request Jul 8, 2022
…ledger#2390)

Signed-off-by: Ilia Churin <churin.ilya@gmail.com>
Signed-off-by: BAStos525 <jungle.vas@yandex.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants