New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[refactor]: Remove adt_const_generics nightly feature #3104
[refactor]: Remove adt_const_generics nightly feature #3104
Conversation
Codecov Report
@@ Coverage Diff @@
## iroha2-dev #3104 +/- ##
==============================================
+ Coverage 62.33% 65.14% +2.81%
==============================================
Files 169 171 +2
Lines 31218 33564 +2346
==============================================
+ Hits 19459 21866 +2407
+ Misses 11759 11698 -61
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
I find approach with enum to be too verbose + const generics enums don't seems to be stabilized soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a huge fan of moving away, but given that the feature is marked as incomplete even though it should not break in any context the fact that this would let people use a stable compiler might be worth the trade-off in terms of readability.
2fa9be4
to
b58b517
Compare
b58b517
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
b58b517
to
7501e91
Compare
Signed-off-by: Marin Veršić marin.versic101@gmail.com
Description of the Change
Relevant discussion
If many of you disagree we'll reject this PR
Issue
Benefits
Possible Drawbacks
Usage Examples or Tests [optional]
Alternate Designs [optional]