Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor]: Remove adt_const_generics nightly feature #3104

Conversation

mversic
Copy link
Contributor

@mversic mversic commented Feb 1, 2023

Signed-off-by: Marin Veršić marin.versic101@gmail.com

Description of the Change

Relevant discussion
If many of you disagree we'll reject this PR

Issue

Benefits

Possible Drawbacks

Usage Examples or Tests [optional]

Alternate Designs [optional]

@github-actions github-actions bot added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Feb 1, 2023
@codecov
Copy link

codecov bot commented Feb 1, 2023

Codecov Report

Merging #3104 (7501e91) into iroha2-dev (a4d5c9f) will increase coverage by 2.81%.
The diff coverage is 71.44%.

@@              Coverage Diff               @@
##           iroha2-dev    #3104      +/-   ##
==============================================
+ Coverage       62.33%   65.14%   +2.81%     
==============================================
  Files             169      171       +2     
  Lines           31218    33564    +2346     
==============================================
+ Hits            19459    21866    +2407     
+ Misses          11759    11698      -61     
Impacted Files Coverage Δ
cli/src/main.rs 1.09% <0.00%> (ø)
cli/src/torii/mod.rs 27.65% <ø> (ø)
cli/src/torii/utils.rs 72.00% <0.00%> (-12.85%) ⬇️
client_cli/src/main.rs 0.24% <0.00%> (-0.01%) ⬇️
config/base/src/lib.rs 91.57% <ø> (+55.21%) ⬆️
config/src/lib.rs 33.33% <ø> (ø)
config/src/logger.rs 70.21% <ø> (ø)
config/src/path.rs 0.00% <0.00%> (ø)
core/src/lib.rs 100.00% <ø> (ø)
core/src/smartcontracts/isi/block.rs 85.71% <ø> (-3.18%) ⬇️
... and 171 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Erigara
Erigara previously approved these changes Feb 1, 2023
Copy link
Contributor

@Erigara Erigara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

I find approach with enum to be too verbose + const generics enums don't seems to be stabilized soon.

SamHSmith
SamHSmith previously approved these changes Feb 1, 2023
appetrosyan
appetrosyan previously approved these changes Feb 1, 2023
Copy link
Contributor

@appetrosyan appetrosyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a huge fan of moving away, but given that the feature is marked as incomplete even though it should not break in any context the fact that this would let people use a stable compiler might be worth the trade-off in terms of readability.

@mversic mversic force-pushed the remove_nightly_const_generics_feature branch from 2fa9be4 to b58b517 Compare February 1, 2023 10:28
@appetrosyan appetrosyan dismissed stale reviews from SamHSmith, Erigara, and themself via b58b517 February 1, 2023 10:29
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
@mversic mversic force-pushed the remove_nightly_const_generics_feature branch from b58b517 to 7501e91 Compare February 1, 2023 10:31
@mversic mversic enabled auto-merge (squash) February 1, 2023 10:37
@mversic mversic merged commit 3d5305a into hyperledger:iroha2-dev Feb 1, 2023
@mversic mversic deleted the remove_nightly_const_generics_feature branch February 1, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants