Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] #3109: Prevent sumeragi sleep after role agnostic message #3110

Merged
merged 3 commits into from
Feb 9, 2023

Conversation

Erigara
Copy link
Contributor

@Erigara Erigara commented Feb 2, 2023

Description of the Change

Changes tend to improve sumeragi message processing speed.

  • Fix bug when iroha sleep after role-agnostic message
  • Refactor view change proof chain and improve it's processing speed.

Issue

Closes #3109.

Benefits

Better sumeragi message processing speed.

Possible Drawbacks

None.

Alternate Designs

There is still problem with:

This peer is faulty. Incoming messages have to be dropped due to low processing speed.

This happens because sumeragi blocks on committing/revalidating block and if it takes time greater than pipeline ViewChangeSuggested start flooding queue.
When queue is full it's staring to drop messages which in turn provoke even more ViewChangeSuggested messages.

@Erigara Erigara added Bug Something isn't working iroha2-dev The re-implementation of a BFT hyperledger in RUST Consensus This issue is related to the Sumeragi consensus labels Feb 2, 2023
@Erigara Erigara self-assigned this Feb 2, 2023
@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Merging #3110 (d9ca349) into iroha2-dev (a16d9c3) will decrease coverage by 3.21%.
The diff coverage is 69.84%.

@@              Coverage Diff               @@
##           iroha2-dev    #3110      +/-   ##
==============================================
- Coverage       67.61%   64.40%   -3.21%     
==============================================
  Files             140      172      +32     
  Lines           26173    34107    +7934     
==============================================
+ Hits            17696    21966    +4270     
- Misses           8477    12141    +3664     
Impacted Files Coverage Δ
actor/src/actor_id.rs 90.00% <ø> (ø)
actor/src/deadlock.rs 85.93% <ø> (-14.07%) ⬇️
cli/src/event.rs 0.00% <0.00%> (-41.87%) ⬇️
cli/src/main.rs 1.09% <0.00%> (-0.26%) ⬇️
cli/src/stream.rs 0.00% <0.00%> (-81.40%) ⬇️
client_cli/src/main.rs 0.24% <0.00%> (-0.02%) ⬇️
config/src/path.rs 0.00% <0.00%> (ø)
core/src/block.rs 43.21% <ø> (-26.79%) ⬇️
core/src/block_sync.rs 21.96% <ø> (-22.55%) ⬇️
core/src/genesis.rs 71.51% <ø> (-18.12%) ⬇️
... and 234 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mversic mversic self-assigned this Feb 2, 2023
mversic
mversic previously approved these changes Feb 6, 2023
mversic
mversic previously approved these changes Feb 7, 2023
SamHSmith
SamHSmith previously approved these changes Feb 8, 2023
…message

Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
@Erigara Erigara merged commit 26da0f0 into hyperledger:iroha2-dev Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Consensus This issue is related to the Sumeragi consensus iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants