-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] #3109: Prevent sumeragi sleep after role agnostic message #3110
Merged
+392
−348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## iroha2-dev #3110 +/- ##
==============================================
- Coverage 67.61% 64.40% -3.21%
==============================================
Files 140 172 +32
Lines 26173 34107 +7934
==============================================
+ Hits 17696 21966 +4270
- Misses 8477 12141 +3664
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mversic
reviewed
Feb 2, 2023
mversic
reviewed
Feb 3, 2023
mversic
previously approved these changes
Feb 6, 2023
mversic
reviewed
Feb 6, 2023
fb8beb6
to
5516f3b
Compare
mversic
previously approved these changes
Feb 7, 2023
SamHSmith
previously approved these changes
Feb 8, 2023
5516f3b
to
163db0c
Compare
SamHSmith
approved these changes
Feb 8, 2023
…message Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
163db0c
to
d9ca349
Compare
mversic
approved these changes
Feb 9, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Bug
Something isn't working
Consensus
This issue is related to the Sumeragi consensus
iroha2-dev
The re-implementation of a BFT hyperledger in RUST
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Changes tend to improve sumeragi message processing speed.
Issue
Closes #3109.
Benefits
Better sumeragi message processing speed.
Possible Drawbacks
None.
Alternate Designs
There is still problem with:
This happens because sumeragi blocks on committing/revalidating block and if it takes time greater than
pipeline
ViewChangeSuggested
start flooding queue.When queue is full it's staring to drop messages which in turn provoke even more
ViewChangeSuggested
messages.