Fix in iroha-cpp library + added example of few transactions (HL branch -> develop) #3148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Grzegorz Bazior <g.bazior@yodiss.pl>
appetrosyan
reviewed
Mar 14, 2023
Arjentix
reviewed
Mar 14, 2023
Arjentix
reviewed
Mar 14, 2023
|
@baziorek You should also amend the sign-offs on the commits. We can't merge without DCO. |
baziorek
commented
Mar 17, 2023
baziorek
force-pushed
the
iroha-cpp-lib-fix-examples
branch
2 times, most recently
from
9d3b6b1
to
0e7f156
Compare
Co-authored-by: Aleksandr Petrosyan <a-p-petrosyan@yandex.ru> Signed-off-by: G. Bazior <gbaz@o2.pl> Signed-off-by: Grzegorz Bazior <g.bazior@yodiss.pl>
Signed-off-by: Grzegorz Bazior <g.bazior@yodiss.pl>
Signed-off-by: Grzegorz Bazior <g.bazior@yodiss.pl>
Signed-off-by: Grzegorz Bazior <g.bazior@yodiss.pl>
baziorek
force-pushed
the
iroha-cpp-lib-fix-examples
branch
from
0e7f156
to
797f9cf
Compare
|
@appetrosyan @Arjentix Thanks for all your suggestions. It looks that I was able to fix them, expect for: Also all commits looks signed: Please let me know if You have any more comments to correct:). |
appetrosyan
approved these changes
Mar 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Grzegorz Bazior g.bazior@yodiss.pl
Description of the Change
I noticed that in examples queries were not working - after some time of investigation I noticed that
countermust be greated than 0, but default value is 0. So I changed into 1. Also I added another example file with error checking (it was my first time with GRPC in C++ so there can be errors)Issue
Benefits
Good example for somebody who wants to start developing Iroha 1 with iroha-cpp-lib + fix
Possible Drawbacks
I don't know what
counteris:D.Usage Examples or Tests [optional]
Alternate Designs [optional]